From: Jamie Lokier <lk@tantalophile.demon.co.uk>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Petr Vandrovec <vandrove@vc.cvut.cz>, linux-kernel@vger.kernel.org
Subject: Re: 2.4.0-test13-pre1 lockup: run_task_queue or tty_io are wrong
Date: Sun, 17 Dec 2000 19:23:51 +0100 [thread overview]
Message-ID: <20001217192351.A18244@pcep-jamie.cern.ch> (raw)
In-Reply-To: <20001217034928.A410@ppc.vc.cvut.cz> <Pine.LNX.4.10.10012161859340.23256-100000@penguin.transmeta.com>
In-Reply-To: <Pine.LNX.4.10.10012161859340.23256-100000@penguin.transmeta.com>; from torvalds@transmeta.com on Sat, Dec 16, 2000 at 07:09:56PM -0800
Linus Torvalds wrote:
> Ho humm. I'll have to check what the proper fix is. Right now the rule is
> that nobody can _ever_ remove himself from a task queue, although there is
> one bad user that does exactly that, and that means that it should be ok
> to just cache the "next" pointer in run_task_queue(), and make it look
> something like
How about using a sentinel list entry representing the current position
in run_task_queue's loop?
The sentinel's next pointer isn't invalidated by other operations on the
list, provided each operation is protected by tqueue_lock. Each
iteration step is a matter or removing the sentinel, and inserting it in
the next position. A task removing itself would then be perfectly ok.
-- Jamie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-12-17 18:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-17 2:49 Petr Vandrovec
2000-12-17 3:09 ` Linus Torvalds
2000-12-17 3:49 ` Petr Vandrovec
2000-12-17 7:25 ` Andrew Morton
2000-12-17 18:23 ` Jamie Lokier [this message]
2000-12-17 20:02 ` Linus Torvalds
2000-12-17 21:05 ` Jeff V. Merkey
2000-12-17 20:23 ` Linus Torvalds
2000-12-18 20:51 ` Jamie Lokier
2000-12-18 23:58 ` Linus Torvalds
2000-12-19 1:32 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001217192351.A18244@pcep-jamie.cern.ch \
--to=lk@tantalophile.demon.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®