From: Russell King <rmk@arm.linux.org.uk>
To: marcelo@conectiva.com.br (Marcelo Tosatti)
Cc: torvalds@transmeta.com (Linus Torvalds),
quintela@fi.udc.es (Juan Quintela),
riel@conectiva.com.br (Rik van Riel),
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove __mark_buffer_dirty and related changes
Date: Fri, 29 Dec 2000 10:31:23 +0000 (GMT) [thread overview]
Message-ID: <200012291031.eBTAVO301699@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.21.0012281627060.12364-100000@freak.distro.conectiva> from "Marcelo Tosatti" at Dec 28, 2000 04:35:21 PM
Marcelo Tosatti writes:
> +int mark_buffer_dirty(struct buffer_head *bh)
> {
> + if (!atomic_set_buffer_dirty(bh)) {
> + return 1;
> + }
> + return 0;
> }
Any particular reason why you don't to:
return !atomic_set_buffer_dirty(bh);
which generates better code on some systems?
_____
|_____| ------------------------------------------------- ---+---+-
| | Russell King rmk@arm.linux.org.uk --- ---
| | | | http://www.arm.linux.org.uk/personal/aboutme.html / / |
| +-+-+ --- -+-
/ | THE developer of ARM Linux |+| /|\
/ | | | --- |
+-+-+ ------------------------------------------------- /\\\ |
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-12-29 11:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-28 15:18 [PATCH] not sleep while holding a locked page in block_truncate_page Marcelo Tosatti
2000-12-28 18:01 ` Linus Torvalds
2000-12-28 16:25 ` Marcelo Tosatti
2000-12-28 18:25 ` Linus Torvalds
2000-12-28 18:35 ` [PATCH] remove __mark_buffer_dirty and related changes Marcelo Tosatti
2000-12-29 10:31 ` Russell King [this message]
2000-12-29 14:16 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200012291031.eBTAVO301699@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=quintela@fi.udc.es \
--cc=riel@conectiva.com.br \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®