mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: safemode@voicenet.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: ip_conntrack locks up hard on 2.4.0 after about 10 hours
Date: Sat, 6 Jan 2001 15:29:39 -0800	[thread overview]
Message-ID: <200101062329.PAA13498@pizda.ninka.net> (raw)
In-Reply-To: <3A573BD2.C7F7771F@voicenet.com> (message from safemode on Sat, 06 Jan 2001 10:37:54 -0500)
In-Reply-To: <3A573BD2.C7F7771F@voicenet.com>

   Date: 	Sat, 06 Jan 2001 10:37:54 -0500
   From: safemode <safemode@voicenet.com>

   Jan  6 06:18:10 icebox kernel: reset_xmit_timer sk=c17fd040 1
   when=0x5d9e, caller=c01a6bf1

I posted a fix for this on Linux-kernel yesterday, had you tested it
you would have seen at least this part of your problem report go away.
I'm reposting the fix for your convenience:

--- net/ipv4/tcp_input.c.~1~	Wed Dec 13 10:31:48 2000
+++ net/ipv4/tcp_input.c	Fri Jan  5 17:01:53 2001
@@ -1705,7 +1705,7 @@
 
 		if ((__s32)when < (__s32)tp->rttvar)
 			when = tp->rttvar;
-		tcp_reset_xmit_timer(sk, TCP_TIME_RETRANS, when);
+		tcp_reset_xmit_timer(sk, TCP_TIME_RETRANS, min(when, TCP_RTO_MAX));
 	}
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  parent reply	other threads:[~2001-01-06 23:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-01-06 15:37 safemode
2001-01-06 15:51 ` safemode
2001-01-06 23:29 ` David S. Miller [this message]
2001-01-07 11:27 ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200101062329.PAA13498@pizda.ninka.net \
    --to=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=safemode@voicenet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®