From: Peter Samuelson <peter@cadcamlab.org>
To: "J . A . Magallon" <jamagallon@able.es>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
"Justin T . Gibbs" <gibbs@scsiguy.com>
Subject: Re: warning in 2.4.1pre10
Date: Wed, 24 Jan 2001 18:45:00 -0600 [thread overview]
Message-ID: <20010124184500.B6941@cadcamlab.org> (raw)
In-Reply-To: <20010125004454.C930@werewolf.able.es>
In-Reply-To: <20010125004454.C930@werewolf.able.es>; from jamagallon@able.es on Thu, Jan 25, 2001 at 12:44:54AM +0100
[J. A. Magallon]
> It is harmless, 'cause the last sentence in the funtion is a panic,
> but it is good to add the 'return 0', just to shut up the compiler.
The correct fix is __attribute__((noreturn)) in the panic() prototype.
As it happens, this has already been done....
Peter
--- 2.3.99pre4pre2/include/linux/raid/md_k.h~ Thu Feb 24 22:02:59 2000
+++ 2.3.99pre4pre2/include/linux/raid/md_k.h Wed Jan 24 18:40:28 2001
@@ -15,6 +15,8 @@
#ifndef _MD_K_H
#define _MD_K_H
+#include <linux/kernel.h> // for panic()
+
#define MD_RESERVED 0UL
#define LINEAR 1UL
#define STRIPED 2UL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-01-25 0:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-24 23:44 J . A . Magallon
2001-01-25 0:45 ` Peter Samuelson [this message]
2001-01-25 0:58 ` J . A . Magallon
2001-01-25 1:33 ` Peter Samuelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010124184500.B6941@cadcamlab.org \
--to=peter@cadcamlab.org \
--cc=gibbs@scsiguy.com \
--cc=jamagallon@able.es \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®