From: Andreas Dilger <adilger@turbolinux.com>
To: Keith Owens <kaos@ocs.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: modversions.h source pollution in 2.4
Date: Mon, 5 Feb 2001 11:16:50 -0700 (MST) [thread overview]
Message-ID: <200102051816.f15IGoT11015@webber.adilger.net> (raw)
In-Reply-To: <26206.981331639@kao2.melbourne.sgi.com> from Keith Owens at "Feb 5, 2001 11:07:19 am"
Keith Owens writes:
> The following files explicitly include linux/modversions.h. They
> should not do this, the Makefiles are responsible for automatically
> including modversions.h. Since modversions.h will disappear in 2.5,
> consider this advance warning that the offending sources can expect
> problems.
>
> Maintainers: please fix these sources by removing modversions.h.
It is not clear from your posting if anything other than removing the
"#include <linux/modversions.h>" line is needed... Also, what kernel
versions is this needed for? The LVM code uses a common source file
for 2.2 and 2.4, so should the #include stay in for 2.2?
Cheers, Andreas
--
Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto,
\ would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/ -- Dogbert
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-02-05 18:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-05 0:07 Keith Owens
2001-02-05 0:12 ` Jeff Garzik
2001-02-05 18:16 ` Andreas Dilger [this message]
2001-02-05 18:21 ` Alan Cox
2001-02-05 20:23 ` Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200102051816.f15IGoT11015@webber.adilger.net \
--to=adilger@turbolinux.com \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®