From: Jean-Luc Leger <reiga@dspnet.claranet.fr>
To: linux-kernel@vger.kernel.org
Subject: mispellings and other preprocessing problems
Date: Mon, 12 Feb 2001 23:48:03 +0100 [thread overview]
Message-ID: <20010212234803.A17684@dspnet.claranet.fr> (raw)
Hi,
I am a computer scientist from France. I currently play with
a source code analyser of mine.
Here are some "bugs" (or are they not ?) it detected :
(my own comments begin with ->)
/usr/src/linux-2.4.1/include/asm-parisc/som.h : EOF in comment
-> this one is self explained ..
/usr/src/linux-2.4.1/drivers/char/dz.c : 233 IDENTIFIER expected in #ifdef
-> line 233 is : #ifdef 0
-> maybe #if 0 ? (and then, it is not so important since cpp understand it
-> correctly)
/usr/src/linux-2.4.1/arch/ia64/sn/io/klgraph_hack.c :
142 IDENTIFIER expected in #ifdef
-> same thing with #ifdef 0
/usr/src/linux-2.4.1/drivers/char/joystick/amijoy.c :
EOF in string started in line 116
-> unknown identifier 'Denise' (probably should be 'i')
-> unexpected double quote which is the origin of the problem
/usr/src/linux-2.4.1/drivers/scsi/NCR5380.c :
2267 NEWLINE expected in #ifdef
-> line 2267 is : #ifdef READ_OVERRUNS if (p & SR_IO) { c -= 2;
-> this line should be split in 2
/usr/src/linux-2.4.1/drivers/atm/nicstar.h : 616 unknown directive
/usr/src/linux-2.4.1/drivers/atm/nicstar.h : 628 unknown directive
-> #eliif in place of #elif
/usr/src/linux-2.4.1/arch/ia64/sn/io/klconflib.c :
514 Constant expression expected in #ifdef
-> closing bracket at wrong position in expression
/usr/src/linux-2.4.1/arch/ia64/sn/io/ml_SN_init.c :
351 NEWLINE expected in #ifdef
-> #ifdef CONFIG_SGI_IP35 || CONFIG_IA64_SGI_SN1 || CONFIG_IA64_GENERIC
-> should be :
-> #if defined (CONFIG_SGI_IP35) || defined(CONFIG_IA64_SGI_SN1)
|| defined(CONFIG_IA64_GENERIC)
That's all. Of course, I advise those who know to check my corrections :)
Thanks for this interesting system :)
JLL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://vger.kernel.org/lkml/
reply other threads:[~2001-02-12 22:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010212234803.A17684@dspnet.claranet.fr \
--to=reiga@dspnet.claranet.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®