From: Mikael Pettersson <mikpe@csd.uu.se>
To: alan@lxorguk.ukuu.org.uk, twaugh@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: 2.4.1-ac breaks parport_pc when CONFIG_PCI=n
Date: Fri, 16 Feb 2001 01:14:01 +0100 (MET) [thread overview]
Message-ID: <200102160014.BAA07108@harpo.it.uu.se> (raw)
2.4.1-ac breaks parport_pc in PCI-less configs.
Attempting to 'make vmlinux' in 2.4.1-ac14 with
# CONFIG_MODULES is not set
# CONFIG_PCI is not set
CONFIG_PARPORT=y
CONFIG_PARPORT_PC=y
results in
drivers/parport/driver.o: In function `parport_pc_init_superio':
drivers/parport/driver.o(.text.init+0x1311): undefined reference to `pci_devices'
drivers/parport/driver.o(.text.init+0x1316): undefined reference to `pci_devices'
drivers/parport/driver.o(.text.init+0x1323): undefined reference to `pci_devices'
make: *** [vmlinux] Error 1
parport_pc_init_superio() contains a pci_for_each_dev loop. This macro
references pci_devices which doesn't exist when CONFIG_PCI=n.
2.4.1 vanilla has a #ifdef CONFIG_PCI/#endif pair around the offending
code, but 2.4.1-ac removes the #ifdef leading to the error above.
Either the #ifdef needs to be put back in, or pci_for_each_dev should
have a dummy #define in <linux/pci.h> for !CONFIG_PCI, like many of the
other pci functions.
/Mikael
reply other threads:[~2001-02-16 0:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200102160014.BAA07108@harpo.it.uu.se \
--to=mikpe@csd.uu.se \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=twaugh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®