mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kuznet@ms2.inr.ac.ru
To: chris@scary.beasts.org (Chris Evans)
Cc: linux-kernel@vger.kernel.org, davem@redhat.com
Subject: Re: SO_SNDTIMEO: 2.4 kernel bugs
Date: Sat, 17 Feb 2001 23:29:14 +0300 (MSK)	[thread overview]
Message-ID: <200102172029.XAA28904@ms2.inr.ac.ru> (raw)
In-Reply-To: <Pine.LNX.4.30.0102170126130.21158-100000@ferret.lmh.ox.ac.uk> from "Chris Evans" at Feb 17, 1 01:35:15 am

Hello!

> Unfortunately, it seems to be very buggy. Here are two buggy scenarios.


--- ../vger3-010210/linux/net/ipv4/tcp.c	Sat Feb 10 23:16:51 2001
+++ linux/net/ipv4/tcp.c	Sat Feb 17 23:27:43 2001
@@ -691,6 +691,8 @@
 
 		set_current_state(TASK_INTERRUPTIBLE);
 
+		if (!timeo)
+			break;
 		if (signal_pending(current))
 			break;
 		if (tcp_memory_free(sk) && !vm_wait)
--- ../vger3-010210/linux/net/core/sock.c	Tue Jan 30 21:20:16 2001
+++ linux/net/core/sock.c	Sat Feb 17 23:27:44 2001
@@ -727,6 +727,8 @@
 	clear_bit(SOCK_ASYNC_NOSPACE, &sk->socket->flags);
 	add_wait_queue(sk->sleep, &wait);
 	for (;;) {
+		if (!timeo)
+			break;
 		if (signal_pending(current))
 			break;
 		set_bit(SOCK_NOSPACE, &sk->socket->flags);

  reply	other threads:[~2001-02-17 20:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-02-17  1:35 Chris Evans
2001-02-17 20:29 ` kuznet [this message]
2001-02-17 21:56   ` Chris Evans
2001-02-17 22:46   ` Chris Evans
2001-02-18 17:24     ` kuznet
2001-02-18 19:25       ` Chris Evans
2001-02-18 19:33         ` kuznet
2001-02-18 19:37           ` Chris Evans
2001-02-18 19:48             ` kuznet
2001-02-19  1:04       ` Chris Evans
2001-02-19  1:43         ` sendfile() breakage was " Chris Evans
2001-02-19 18:03         ` kuznet
2001-02-19 21:56           ` Chris Evans
2001-02-20 15:09             ` David Woodhouse
2001-02-18  1:50   ` Chris Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200102172029.XAA28904@ms2.inr.ac.ru \
    --to=kuznet@ms2.inr.ac.ru \
    --cc=chris@scary.beasts.org \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®