mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Peter T. Breuer" <ptb@it.uc3m.es>
To: "Jens Axboe" <axboe@suse.de>
Cc: "linux kernel" <linux-kernel@vger.kernel.org>
Subject: Re: plugging in 2.4. Does it work?
Date: Wed, 21 Feb 2001 00:32:08 +0100 (MET)	[thread overview]
Message-ID: <200102202332.f1KNW8S02052@oboe.it.uc3m.es> (raw)
In-Reply-To: <20010220235813.B811@suse.de> from "Jens Axboe" at "Feb 20, 2001 11:58:13 pm"

"A month of sundays ago Jens Axboe wrote:"
> Forgot to mention that the above doesn't make much sense at all. If
> there are no errors, you loop through ending all the buffers. Then

Yes, that's right, thanks. I know I do one more end_that_request_first
than is necessary, but it is harmless as there is a guard in the 
kernel code. At least, it's harmless until someone removes that guard.

It is like that because I added the while loop to the front of the code I
already had working when I decided to try plugging.

> you fall through and end the the first (non-existant) chunk? And
> end_that_request_first does not need to hold the io_request_lock,
> you can move that down to protect end_that_request_last.

OK, thanks!

Peter

  reply	other threads:[~2001-02-20 23:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-02-20 22:41 Peter T. Breuer
2001-02-20 22:54 ` Jens Axboe
2001-02-20 23:27   ` Peter T. Breuer
2001-02-20 23:37     ` Jens Axboe
2001-02-20 23:48       ` Peter T. Breuer
2001-02-20 23:52         ` Jens Axboe
2001-02-20 22:58 ` Jens Axboe
2001-02-20 23:32   ` Peter T. Breuer [this message]
2001-02-21 15:36 Peter T. Breuer
2001-02-21 17:27 ` Jens Axboe
2001-02-21 17:54   ` Peter T. Breuer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200102202332.f1KNW8S02052@oboe.it.uc3m.es \
    --to=ptb@it.uc3m.es \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®