From: Zach Brown <zab@zabbo.net>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] pci_dma_set_mask()
Date: Wed, 28 Feb 2001 16:14:50 -0500 [thread overview]
Message-ID: <20010228161450.A25553@tetsuo.zabbo.net> (raw)
In-Reply-To: <20010228103727.I23735@tetsuo.zabbo.net> <3A9D26A2.14563DE1@mandrakesoft.com>
In-Reply-To: <3A9D26A2.14563DE1@mandrakesoft.com>; from jgarzik@mandrakesoft.com on Wed, Feb 28, 2001 at 11:26:10AM -0500
> pci_dma_supported has a boolean return, but the kernel norm is to return
> zero on success, and -EFOO on error. I like your proposal with the
*nod* I just followed pci_dma_supported().
> extremely minor nit that I think pci_set_dma_mask should return ENODEV
> or EIO or something on error, and zero on success.
I agree, though I'd like to leave the decision up to people who live and
breathe this stuff.
please feel free to make minor adjustments and submit :)
- z
next prev parent reply other threads:[~2001-02-28 21:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-28 15:37 Zach Brown
2001-02-28 16:26 ` Jeff Garzik
2001-02-28 21:14 ` Zach Brown [this message]
2001-02-28 23:23 ` David S. Miller
2001-02-28 23:37 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010228161450.A25553@tetsuo.zabbo.net \
--to=zab@zabbo.net \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®