Re: [OT] style-curiosity

["J . A . Magallon" <jamagallon@able.es>]

On 03.02 Tigran Aivazian wrote:
> On Fri, 2 Mar 2001, J . A . Magallon wrote:
> > for (c = misc_list.next; c != &misc_list; c = c->next)
> > {
> > 	if (c->minor == misc->minor) {
> > 		up(&misc_sem);
> > 		return -EBUSY;
> > 	}	
> > }
> 
> the above is good but the below is better:
> 
> for (c = misc_list.next; c != &misc_list; c = c->next)
>        if (c->minor == misc->minor) {
>                up(&misc_sem);
>                return -EBUSY;
>        }
>

I have suffered so many bugs coming from bad grouping that I always put
the braces even if they are not needed.

-- 
J.A. Magallon                                                      $> cd pub
mailto:jamagallon@able.es                                          $> more beer

Linux werewolf 2.4.2-ac8 #2 SMP Fri Mar 2 12:12:45 CET 2001 i686