From: David Hinds <dhinds@sonic.net>
To: Linus Torvalds <torvalds@transmeta.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Bug in cardbus initialization, or am I missing something?
Date: Sat, 3 Mar 2001 09:58:19 -0800 [thread overview]
Message-ID: <20010303095819.A16963@sonic.net> (raw)
In drivers/pcmcia/cardbus.c in cb_alloc(), PCI_INTERRUPT_LINE and
dev->irq are not filled in until after calling pci_enable_device().
The result is a cryptic message like:
> PCI: No IRQ known for interrupt pin A of device 01:00.0. Please try using pci=biosirq.
Unless there is a less obvious reason for the ordering, I suggest the
following one-liner.
-- Dave Hinds
--- cardbus.c.orig Fri Mar 2 09:49:46 2001
+++ cardbus.c Fri Mar 2 09:50:28 2001
@@ -288,7 +288,6 @@
if (res->flags)
pci_assign_resource(dev, r);
}
- pci_enable_device(dev); /* XXX check return */
/* Does this function have an interrupt at all? */
pci_readb(dev, PCI_INTERRUPT_PIN, &irq_pin);
@@ -297,6 +296,7 @@
pci_writeb(dev, PCI_INTERRUPT_LINE, irq);
}
+ pci_enable_device(dev); /* XXX check return */
pci_insert_device(dev, bus);
}
next reply other threads:[~2001-03-03 17:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-03 17:58 David Hinds [this message]
2001-03-03 18:49 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010303095819.A16963@sonic.net \
--to=dhinds@sonic.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®