From: Philipp Rumpf <prumpf@mandrakesoft.com>
To: Andrey Panin <pazke@orbita.don.sitek.net>
Cc: linux-kernel@vger.kernel.org, tytso@valinux.com
Subject: Re: [PATCH] /drivers/char/serial.c cleanup
Date: Mon, 5 Mar 2001 06:48:29 -0600 [thread overview]
Message-ID: <20010305064829.A654@mandrakesoft.mandrakesoft.com> (raw)
In-Reply-To: <20010305153704.A20753@debian>
In-Reply-To: <20010305153704.A20753@debian>; from Andrey Panin on Mon, Mar 05, 2001 at 03:37:04PM +0300
On Mon, Mar 05, 2001 at 03:37:04PM +0300, Andrey Panin wrote:
> Attached patch (2.4.2-ac11) makes some changes in serial driver:
> adds ioremap() return code checks, removes panic() calls
> and adds better error handling in start_pci_pnp_board() function.
Did you test it ?
> diff -u /linux.vanilla/drivers/char/serial.c /linux/drivers/char/serial.c
> --- /linux.vanilla/drivers/char/serial.c Thu Mar 1 20:15:43 2001
> +++ /linux/drivers/char/serial.c Fri Mar 2 00:10:29 2001
> @@ -3876,7 +3876,10 @@
> return 0;
> }
> req->io_type = SERIAL_IO_MEM;
> - req->iomem_base = ioremap(port, board->uart_offset);
> + if ((req->iomem_base = ioremap(port, board->uart_offset))) {
> + printk(KERN_ERR "serial: Couldn's remap IO memory at %#lx\n", port);
> + return 1;
> + }
This seems wrong. ioremap returns NULL in case of failure.
next prev parent reply other threads:[~2001-03-05 12:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-05 12:37 Andrey Panin
2001-03-05 12:48 ` Philipp Rumpf [this message]
2001-03-05 12:59 ` Andrey Panin
2001-03-05 15:44 ` tytso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010305064829.A654@mandrakesoft.mandrakesoft.com \
--to=prumpf@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pazke@orbita.don.sitek.net \
--cc=tytso@valinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®