mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dawson Engler <engler@csl.Stanford.EDU>
To: jgarzik@mandrakesoft.com (Jeff Garzik)
Cc: linux-kernel@vger.kernel.org, mc@cs.Stanford.EDU
Subject: Re: [CHECKER] 28 potential interrupt errors
Date: Sun, 18 Mar 2001 17:53:10 -0800 (PST)	[thread overview]
Message-ID: <200103190153.RAA23378@csl.Stanford.EDU> (raw)
In-Reply-To: <3AB4A162.17FD434A@mandrakesoft.com> from "Jeff Garzik" at Mar 18, 2001 06:52:02 AM

> Request:  can the checker check for skb's being freed correctly?  The
> rules:
> 
> If an skb is in interrupt context, call dev_kfree_skb_irq.
> If an skb might be in interrupt context, call dev_kfree_skb_any.
> If an skb is not in interrupt context, call dev_kfree_skb.

It shouldn't be hard to check this.  The only thing interesting will be
deriving when you're in an interrupt context.  Thanks for the pointer.
Are there other context-sensitive rules that we could go after as well?

> I dunno WTF the programmer was thinking here...  Your de-ref checker
> should have caught this too:  check 'lp' for NULL after de-referencing
> lp->lock.

These reports are for an older version of the checker --- we've fixed
some bugs in the system, which should catch more of these errors.

Dawson

      reply	other threads:[~2001-03-19  1:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-17  6:18 Junfeng Yang
2001-03-17 12:03 ` Andrew Morton
2001-03-17 21:29   ` Junfeng Yang
2001-03-17 22:42 ` David Woodhouse
2001-03-18  0:03   ` Andrew Morton
2001-03-18 13:07     ` David Woodhouse
2001-03-18 18:03     ` Kai Germaschewski
2001-03-18 11:52 ` Jeff Garzik
2001-03-19  1:53   ` Dawson Engler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200103190153.RAA23378@csl.Stanford.EDU \
    --to=engler@csl.stanford.edu \
    --cc=jgarzik@mandrakesoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mc@cs.Stanford.EDU \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®