mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kuznet@ms2.inr.ac.ru
To: green@dredd.crimea.edu (Oleg Drokin)
Cc: linux-kernel@vger.kernel.org, davem@redhat.com, david-b@pacbell.net
Subject: Re: IP layer bug?
Date: Sat, 31 Mar 2001 19:32:48 +0400 (MSK DST)	[thread overview]
Message-ID: <200103311532.TAA20809@ms2.inr.ac.ru> (raw)
In-Reply-To: <20010331190314.A27130@dredd.crimea.edu> from "Oleg Drokin" at Mar 31, 1 07:03:14 pm

Hello!

> Hm. But comment in linux/skbuff.h says:

The comment is about more difficult case: transmit path,
where cb is used both by top level protocol and lower layers:
f.e. TCP -> IP -> device. cb is dirty from the moment of skb
creation in this case.

Also, note that the second sentence in the comment is obsolete.
Passing not cloned skbs between layers is strongly deprecated
practice (I hope it is not used in any place) and cb of skb entering
to lower layer is property of the layer.

RX path is simpler: cb must be kept clean, that's all.

General rule is minimization redundant clearings of the area.

> Why not document it somewhere, so that others will not fall into the same trap?

Indeed. 8) You got the experience, which you expect to be useful
for people, it is time to prepare some note recording this. 8)

Alexey

  reply	other threads:[~2001-03-31 15:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-24 21:57 Oleg Drokin
2001-03-26 10:36 ` Manoj Sontakke
2001-03-26  6:09   ` Oleg Drokin
2001-03-26 12:21     ` Manoj Sontakke
2001-03-26  7:02       ` Oleg Drokin
2001-03-30 17:13 ` kuznet
2001-03-31 15:03   ` Oleg Drokin
2001-03-31 15:32     ` kuznet [this message]
2001-04-02  9:25       ` Oleg Drokin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200103311532.TAA20809@ms2.inr.ac.ru \
    --to=kuznet@ms2.inr.ac.ru \
    --cc=davem@redhat.com \
    --cc=david-b@pacbell.net \
    --cc=green@dredd.crimea.edu \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®