mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrzej Krzysztofowicz <ankry@pg.gda.pl>
To: ted@cypress.com (Thomas Dodd)
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk (Alan Cox)
Subject: Re: Config printk buffer size
Date: Thu, 5 Apr 2001 11:47:04 +0200 (MET DST)	[thread overview]
Message-ID: <200104050947.LAA08111@sunrise.pg.gda.pl> (raw)
In-Reply-To: <3ACBB9B8.72792AAA@cypress.com> from "Thomas Dodd" at Apr 04, 2001 07:18:00 PM


"Thomas Dodd wrote:"
> diff -u --new-file --recursive linux-2.4.3-ac2.orig/kernel/printk.c linux-2.4.3-ac2/kernel/printk.c
> --- linux-2.4.3-ac2.orig/kernel/printk.c	Wed Apr  4 15:23:31 2001
> +++ linux-2.4.3-ac2/kernel/printk.c	Wed Apr  4 16:01:28 2001
> @@ -27,7 +27,7 @@
>  
>  #include <asm/uaccess.h>
>  
> -#define LOG_BUF_LEN	(16384)			/* This must be a power of two */
> +#define LOG_BUF_LEN (CONFIG_PRINTK_BUF_LEN*1024) /* This must be a power of two */
>  #define LOG_BUF_MASK	(LOG_BUF_LEN-1)
>  

IMO, it would be nice to add a test here whether the CONFIG_PRINTK_BUF_LEN
value is really set as a power of two, eg.:

#if (LOG_BUF_LEN & LOG_BUF_MASK)
#error CONFIG_PRINTK_BUF_LEN must be a power of two
#endif

(above works with egcs-2.91.66)

Andrzej

  reply	other threads:[~2001-04-05 11:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-05  0:18 Thomas Dodd
2001-04-05  9:47 ` Andrzej Krzysztofowicz [this message]
2001-04-05 14:46   ` Thomas Dodd
     [not found] <E14kxha-000366-00@the-village.bc.nu>
2001-04-05 20:36 ` Thomas Dodd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200104050947.LAA08111@sunrise.pg.gda.pl \
    --to=ankry@pg.gda.pl \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=ankry@green.mif.pg.gda.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ted@cypress.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®