mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jeff V. Merkey" <jmerkey@vger.timpanogas.org>
To: Alexander Viro <viro@math.psu.edu>
Cc: linux-kernel@vger.kernel.org, jmerkey@timpanogas.org,
	Linus Torvalds <torvalds@transmeta.com>,
	Linux390@de.ibm.com
Subject: Re: EXPORT_SYMBOL for chrdev_open 2.4.3
Date: Fri, 13 Apr 2001 19:36:57 -0600	[thread overview]
Message-ID: <20010413193657.B15009@vger.timpanogas.org> (raw)
In-Reply-To: <20010413183810.A14604@vger.timpanogas.org> <Pine.GSO.4.21.0104132125180.24992-100000@weyl.math.psu.edu>
In-Reply-To: <Pine.GSO.4.21.0104132125180.24992-100000@weyl.math.psu.edu>; from viro@math.psu.edu on Fri, Apr 13, 2001 at 09:29:43PM -0400

On Fri, Apr 13, 2001 at 09:29:43PM -0400, Alexander Viro wrote:
> 
> On Fri, 13 Apr 2001, Jeff V. Merkey wrote:
> 
> > How are folks supposed to open disk and tape devices from kernel modules
> > without these?  Not everything should be done in user space Al.  If you 
> 
> Normally - filp_open(). If all you want is ioctl on block device -
> blkdev_get() + ioctl_by_bdev() + blkdev_put(). If you want it by
> device _number_ - use bdget().
> 
> > remove blkdev_open I will not be able to properly increment the use 
> > count an a disk device I may be reading or writing to.  
> 


> 	Yes, you will. And I would _really_ advice you to do that by
> name instead of device number - that way you will avoid a lot of pain
> couple of years down the road.


This is **VERY** good to know, and also shows that you in fact have
looked through my code.  

:-)

Jeff



      reply	other threads:[~2001-04-14  1:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-13 23:32 Jeff V. Merkey
2001-04-14  0:13 ` Alexander Viro
2001-04-14  0:38   ` Jeff V. Merkey
2001-04-14  0:47     ` Jeff V. Merkey
2001-04-14  1:25       ` Alexander Viro
2001-04-14  1:35         ` Jeff V. Merkey
2001-04-14  2:12           ` Alexander Viro
2001-04-14  1:29     ` Alexander Viro
2001-04-14  1:36       ` Jeff V. Merkey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010413193657.B15009@vger.timpanogas.org \
    --to=jmerkey@vger.timpanogas.org \
    --cc=Linux390@de.ibm.com \
    --cc=jmerkey@timpanogas.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®