From: R.E.Wolff@BitWizard.nl (Rogier Wolff)
To: hpa@transmeta.com, Linus Torvalds <Torvalds@transmeta.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: [PATCH] Aligning the CPU capabilities flags.
Date: Mon, 16 Apr 2001 10:20:52 +0200 (MEST) [thread overview]
Message-ID: <200104160820.KAA04117@cave.bitwizard.nl> (raw)
Human eyes are wonderful things. They do pattern matching given
the right input. Compare:
CPU: After vendor init, caps: 0183f9ff c1c7f9ff 00000000 00000000
CPU: After generic, caps: 0183f9ff c1c7f9ff 00000000 00000000
CPU: Common caps: 0183f9ff c1c7f9ff 00000000 00000000
with:
CPU: After vendor init, caps: 0183f9ff c1c7f9ff 00000000 00000000
CPU: After generic, caps: 0183f9ff c1c7f9ff 00000000 00000000
CPU: Common caps: 0183f9ff c1c7f9ff 00000000 00000000
In the second case it's immediately obivous nothing changed during
these steps.
Patch below.
Roger.
diff -ur linux-2.4.3.clean/arch/i386/kernel/setup.c linux-2.4.3.cpuflagsfix/arch/i386/kernel/setup.c
--- linux-2.4.3.clean/arch/i386/kernel/setup.c Mon Apr 2 10:02:33 2001
+++ linux-2.4.3.cpuflagsfix/arch/i386/kernel/setup.c Mon Apr 16 10:14:59 2001
@@ -2064,7 +2064,7 @@
/* Now the feature flags better reflect actual CPU features! */
- printk(KERN_DEBUG "CPU: After generic, caps: %08x %08x %08x %08x\n",
+ printk(KERN_DEBUG "CPU: After generic, caps: %08x %08x %08x %08x\n",
c->x86_capability[0],
c->x86_capability[1],
c->x86_capability[2],
@@ -2082,7 +2082,7 @@
boot_cpu_data.x86_capability[i] &= c->x86_capability[i];
}
- printk(KERN_DEBUG "CPU: Common caps: %08x %08x %08x %08x\n",
+ printk(KERN_DEBUG "CPU: Common caps: %08x %08x %08x %08x\n",
boot_cpu_data.x86_capability[0],
boot_cpu_data.x86_capability[1],
boot_cpu_data.x86_capability[2],
--
** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2137555 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
* There are old pilots, and there are bold pilots.
* There are also old, bald pilots.
reply other threads:[~2001-04-16 8:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200104160820.KAA04117@cave.bitwizard.nl \
--to=r.e.wolff@bitwizard.nl \
--cc=Torvalds@transmeta.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hpa@transmeta.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®