From: Martin Mares <mj@suse.cz>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: PATCH 2.4.4.3: pci_enable/disable_device stuff
Date: Tue, 17 Apr 2001 00:35:58 +0200 [thread overview]
Message-ID: <20010417003558.B270@albireo.ucw.cz> (raw)
In-Reply-To: <3AD962D3.2E6E6DC1@mandrakesoft.com>
In-Reply-To: <3AD962D3.2E6E6DC1@mandrakesoft.com>; from jgarzik@mandrakesoft.com on Sun, Apr 15, 2001 at 04:58:59AM -0400
Hi!
> The attached patch does two things:
>
> 1) Take PCI devices to D0 state before enabling them. We both think
> this is the right thing to do, but there is always the crazy chance this
> change will break something. So, think twice before applying, but IMHO
> apply :)
I'm not able to cite the PCI PM specs by heart :) ... but looks OK to me.
> 2) Adds pci_disable_device. Right now is just disables busmastering.
> When suspending devices, the last task that should occur is to disable
> busmastering, before ceding control to ACPI. Also its a good idea in
> general to disable busmastering when its not in use; it's friendlier to
> the bus.
OK.
> When unloading drivers too, we should be more "green" about
> disabling devices.
Yes, but not before we're sure we can wake them up correctly. Probably
also needs to handle wakeup of PCI-to-PCI bridges.
> I wonder if we should disable IO and MEM decoding too, and I also like
> to ack PCI_STATUS. I didn't add those things because I'm not yet sure
> we want to do that unconditionally.
I'd rather prefer to avoid this. It brings nothing except for possible
problems.
Have a nice fortnight
--
Martin `MJ' Mares <mj@ucw.cz> <mj@suse.cz> http://atrey.karlin.mff.cuni.cz/~mj/
Compatible: Gracefully accepts erroneous data from any source.
prev parent reply other threads:[~2001-04-16 22:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-15 8:58 Jeff Garzik
2001-04-16 22:35 ` Martin Mares [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010417003558.B270@albireo.ucw.cz \
--to=mj@suse.cz \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®