mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Phillips <phillips@nl.linux.org>
To: linux-kernel@vger.kernel.org
Cc: viro@math.psu.edu
Subject: Re: [PATCH][CFT] ext2 directories in pagecache
Date: Thu, 19 Apr 2001 03:01:12 +0200	[thread overview]
Message-ID: <20010419010122Z92249-1659+6@humbolt.nl.linux.org> (raw)

Al Viro wrote:
> Folks, IMO ext2-dir-patch got to the stable stage. Currently
> it's against 2.4.4-pre2, but it should apply to anything starting with
> 2.4.2 or so.
> 
> 	Ted, could you review it for potential inclusion into 2.4 once
> it gets enough testing? It's ext2-only (the only change outside of
> ext2 is exporting waitfor_one_page()), it doesn't change fs layout,
> it seriously simplifies ext2/dir.c and ext2/namei.c and it gives better
> VM behaviour.
> 
> 	Patch is on ftp.math.psu.edu/pub/viro/ext2-dir-patch.gz
> 
> 	Folks, please give it a good beating - it works here, but I'd
> really like it to get wide testing. Help would be very welcome.

I'm pretty familiar with this code since I hacked on it pretty extensively
last  month and it does what it tries to do pretty well.  However it relies
heavily on the assumption that directory blocks can be grouped into page-sized
units.  This assumption doesn't hold in my directory indexing code, and I
don't see any clean way to extend the approach you use in this patch to my
index design.

On the other hand, there is an alternative approach, suggested to me by
Stephen Tweedie, that will run just as fast as this code and have a lot less
cruft in it, namely - perform buffer operations on the underlying buffers in
the page cache.  Now perhaps we should discuss that idea and see if it goes
anywhere.

Aside from the part that's tied to the page cache, your patch is generally a
whole lot nicer to read that the original, and I have already incorporated
parts of it in my directory index patch.

--
Daniel

             reply	other threads:[~2001-04-19  1:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-19  1:01 Daniel Phillips [this message]
  -- strict thread matches above, loose matches on Subject: below --
2001-04-12 16:33 Alexander Viro
2001-04-18 12:44 ` James Lewis Nance
2001-04-18 13:08   ` Alexander Viro
2001-04-18 13:01 ` Anton Altaparmakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010419010122Z92249-1659+6@humbolt.nl.linux.org \
    --to=phillips@nl.linux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®