mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Phillips <phillips@nl.linux.org>
To: riel@conectiva.com.br, viro@math.psu.edu
Cc: adilger@turbolinux.com, ext2-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, phillips@nl.linux.org
Subject: Re: Ext2 Directory Index - Delete Performance
Date: Thu, 19 Apr 2001 13:44:03 +0200	[thread overview]
Message-ID: <20010419114416Z92314-11620+7@humbolt.nl.linux.org> (raw)

> On Wed, 18 Apr 2001, Rik van Riel wrote:
> > One thing we should do is make sure the buffer cache code sets
> > the referenced bit on pages, so we don't recycle buffer cache
> > pages early.
> >
> > This should leave more space for the buffercache and lead to us
> > reclaiming the (now unused) space in the dentry cache instead...
> 
> Sorry, but that's just plain wrong. We shouldn't keep inode table in
> buffer-cache at all. And we should be more aggressive on icache -
> dcache looks sane now (recent 2.4.4-pre), but icache holds unused
> inodes for too long. And freeing them is very slow _and_ random -
> recipe for kmem_cache fragmentation.
>  
> /me sits down to port inode-table-in-pagecache to 2.4.4-pre4...

The Ext2 inode-table maps nicely to the page cache with the current
page cache interface because it has uniform sized chunks that are accessed one
at a time, and likewise for the group descriptor cache.

*But* the directory code in page cache with your current approach does not
work out nicely with my directory index - it doesn't have page-sized chunks
and access to them is overlapped.  This isn't an isolated problem, it's a
problem we've managed to avoid dealing with so far because much of the file
code we have does satisfy your two pre-conditions:

  - Data groups naturally into pages
  - Access to data items is strictly serial

We need a way of accessing the page cache that doesn't rely on either of
those two assumptions.
--
Daniel

             reply	other threads:[~2001-04-19 11:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-19 11:44 Daniel Phillips [this message]
  -- strict thread matches above, loose matches on Subject: below --
2001-04-19 10:55 Daniel Phillips
2001-04-19 10:42 Daniel Phillips
2001-04-19  1:22 Daniel Phillips
2001-04-19  3:02 ` Rik van Riel
2001-04-19  3:18   ` Alexander Viro
2001-04-19  0:27 Daniel Phillips
2001-04-19  1:11 ` Jan Harkes
2001-04-19  2:45 ` Rik van Riel
2001-04-19  3:23   ` Alexander Viro
2001-04-19  3:35     ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010419114416Z92314-11620+7@humbolt.nl.linux.org \
    --to=phillips@nl.linux.org \
    --cc=adilger@turbolinux.com \
    --cc=ext2-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riel@conectiva.com.br \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®