From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: David Howells <dhowells@cambridge.redhat.com>
Cc: "David S. Miller" <davem@redhat.com>,
torvalds@transmeta.com, dhowells@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] generic rw_semaphores, compile warnings patch
Date: Fri, 20 Apr 2001 16:04:43 +0400 [thread overview]
Message-ID: <20010420160443.A12528@jurassic.park.msu.ru> (raw)
In-Reply-To: <15071.30776.914468.900710@pizda.ninka.net> <24459.987753038@warthog.cambridge.redhat.com>
In-Reply-To: <24459.987753038@warthog.cambridge.redhat.com>; from dhowells@cambridge.redhat.com on Fri, Apr 20, 2001 at 08:50:38AM +0100
On Fri, Apr 20, 2001 at 08:50:38AM +0100, David Howells wrote:
> There's also a missing "struct rw_semaphore;" declaration in linux/rwsem.h. It
> needs to go in the gap below "#include <linux/wait.h>". Otherwise the
> declarations for the contention handling functions will give warnings about
> the struct being declared in the parameter list.
Also on alpha __u16 is undeclared in rwsem.c, and old rwsem code wasn't
cleaned up properly.
Ivan.
--- 2.4.4p5/include/linux/rwsem-spinlock.h Fri Apr 20 14:06:50 2001
+++ linux/include/linux/rwsem-spinlock.h Fri Apr 20 15:37:28 2001
@@ -14,6 +14,8 @@
#ifdef __KERNEL__
+#include <linux/types.h>
+
/*
* the semaphore definition
*/
--- 2.4.4p5/include/asm-alpha/semaphore.h Fri Apr 20 13:53:28 2001
+++ linux/include/asm-alpha/semaphore.h Fri Apr 20 15:37:28 2001
@@ -225,5 +225,3 @@ extern inline void up(struct semaphore *
#endif
#endif
-
-#endif
--- 2.4.4p5/arch/alpha/kernel/alpha_ksyms.c Fri Apr 20 13:52:56 2001
+++ linux/arch/alpha/kernel/alpha_ksyms.c Fri Apr 20 14:01:36 2001
@@ -173,9 +173,6 @@ EXPORT_SYMBOL(down);
EXPORT_SYMBOL(down_interruptible);
EXPORT_SYMBOL(down_trylock);
EXPORT_SYMBOL(up);
-EXPORT_SYMBOL(__down_read_failed);
-EXPORT_SYMBOL(__down_write_failed);
-EXPORT_SYMBOL(__rwsem_wake);
EXPORT_SYMBOL(down_read);
EXPORT_SYMBOL(down_write);
EXPORT_SYMBOL(up_read);
next prev parent reply other threads:[~2001-04-20 12:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-19 23:33 D.W.Howells
2001-04-19 23:43 ` David S. Miller
2001-04-20 7:50 ` David Howells
2001-04-20 12:04 ` Ivan Kokshaysky [this message]
2001-04-20 7:57 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010420160443.A12528@jurassic.park.msu.ru \
--to=ink@jurassic.park.msu.ru \
--cc=davem@redhat.com \
--cc=dhowells@cambridge.redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®