From: Zach Brown <zab@zabbo.net>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org, maestro-users@zabbo.net
Subject: [PATCH] maestro3 2.4.4-pre5 fixes
Date: Sat, 21 Apr 2001 10:54:13 -0400 [thread overview]
Message-ID: <20010421105413.B8818@erasmus.off.net> (raw)
The maestro3 driver has a error cleanup bug that would leave its reboot
notifier registerd after exiting init_module with an error. Bayad.
It also had a minor bug where it didn't explicitly set the codec->id
before probing..
this patch vs 2.4.4-pre5 (I hope, its really vs jeff's cvs :)) fixes both.
Linus, please apply.
--
zach
Index: maestro3.c
===================================================================
RCS file: /cvsroot/gkernel/linux_2_4/drivers/sound/maestro3.c,v
retrieving revision 1.1.1.24.6.1
diff -u -r1.1.1.24.6.1 maestro3.c
--- maestro3.c 2001/04/20 01:40:38 1.1.1.24.6.1
+++ maestro3.c 2001/04/21 14:36:21
@@ -2307,6 +2307,8 @@
codec->private_data = card;
codec->codec_read = m3_ac97_read;
codec->codec_write = m3_ac97_write;
+ /* someday we should support secondary codecs.. */
+ codec->id = 0;
if (ac97_probe_codec(codec) == 0) {
printk(KERN_ERR PFX "codec probe failed\n");
@@ -2933,6 +2935,7 @@
if (!pci_register_driver(&m3_pci_driver)) {
pci_unregister_driver(&m3_pci_driver);
+ unregister_reboot_notifier(&m3_reboot_nb);
return -ENODEV;
}
return 0;
reply other threads:[~2001-04-21 14:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010421105413.B8818@erasmus.off.net \
--to=zab@zabbo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=maestro-users@zabbo.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®