Re: __alloc_pages: 4-order allocation failed

["Jeff V. Merkey" <jmerkey@vger.timpanogas.org>]

On Thu, Apr 26, 2001 at 08:00:12PM +0200, Szabolcs Szakacsits wrote:
> 
> On Thu, 26 Apr 2001, Jeff V. Merkey wrote:

The request should fail after two or three attempts rather than hang
the entire system waiting for memory.

Jeff

> 
> > I am seeing this as well on 2.4.3 with both _get_free_pages() and
> > kmalloc().  In the kmalloc case, the modules hang waiting
> > for memory.
> 
> One possible source of this hang is due to the change below in
> 2.4.3, non GPF_ATOMIC and non-recursive allocations (PF_MEMALLOC is set)
> will loop until the requested continuous memory is available.
> 
> 	Szaka
> 
> diff -u --recursive --new-file v2.4.2/linux/mm/page_alloc.c
> linux/mm/page_alloc.c--- v2.4.2/linux/mm/page_alloc.c        Sat Feb  3
> 19:51:32 2001
> +++ linux/mm/page_alloc.c       Tue Mar 20 15:05:46 2001
> @@ -455,8 +455,7 @@
>                         memory_pressure++;
>                         try_to_free_pages(gfp_mask);
>                         wakeup_bdflush(0);
> -                       if (!order)
> -                               goto try_again;
> +                       goto try_again;
>                 }
>         }
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/