From: martin@fatbob.nu
To: "Carlo E. Prelz" <fluido@fluido.as>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.4.4, 2.4.4-ac1 and -ac3: oops loading future domain scsi module
Date: Wed, 2 May 2001 14:53:05 +0200 [thread overview]
Message-ID: <20010502145305.B6889@kungen.fatbob.nu> (raw)
In-Reply-To: <20010502083018.A5717@qn-212-127-137-79.fluido.as> <20010502090359.A484@qn-212-127-137-79.fluido.as>
In-Reply-To: <20010502090359.A484@qn-212-127-137-79.fluido.as>; from fluido@fluido.as on Wed, May 02, 2001 at 09:03:59AM +0200
On Wed, May 02, 2001 at 09:03:59AM +0200, Carlo E. Prelz wrote:
> Subject: 2.4.4, 2.4.4-ac1 and -ac3: oops loading future domain scsi module
> Date: Wed, May 02, 2001 at 08:30:18AM +0200
>
> Quoting Carlo E. Prelz (fluido@fluido.as):
>
> > Here I am with another, fresh oops that I encountered while exploring
> > new kernels. This time, the oops is generated when trying to load the
> > module for a very old (1993) Future Domain SCSI card. 2.4.3-ac7 was my
> > previous kernel and worked perfectly.
>
> I made some more research. Eventually, it seems the problem is in this
> patch that was included in 2.4.4:
>
> @@ -969,6 +971,7 @@
> return 0;
> shpnt->irq = interrupt_level;
> shpnt->io_port = port_base;
> + scsi_set_pci_device(shpnt->pci_dev, pdev);
> shpnt->n_io_port = 0x10;
> print_banner( shpnt );
>
> Well, but my card is ISA! It should not set any PCI device.
>
> I applied the following patch, and the problem disappeared:
>
> --- fdomain.c~ Wed May 2 07:08:27 2001
> +++ fdomain.c Wed May 2 08:58:03 2001
> @@ -971,6 +971,7 @@
> return 0;
> shpnt->irq = interrupt_level;
> shpnt->io_port = port_base;
> + if(pdev!=NULL)
> scsi_set_pci_device(shpnt->pci_dev, pdev);
> shpnt->n_io_port = 0x10;
> print_banner( shpnt );
>
> I hope this is the right way...
Well I got the same oops with a PCI card...
After some research I found that the first argument to the inline
function scsi_set_pci_device is supposed to be a pointer to a
struct Scsi_Host.
The patch below should work for both ISA and PCI.
Regards
/Martin
--- fdomain.c.orig Wed May 2 13:33:09 2001
+++ fdomain.c Wed May 2 14:04:45 2001
@@ -971,7 +971,7 @@
return 0;
shpnt->irq = interrupt_level;
shpnt->io_port = port_base;
- scsi_set_pci_device(shpnt->pci_dev, pdev);
+ scsi_set_pci_device(shpnt, pdev);
shpnt->n_io_port = 0x10;
print_banner( shpnt );
prev parent reply other threads:[~2001-05-02 12:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-02 6:30 Carlo E. Prelz
2001-05-02 7:03 ` Carlo E. Prelz
2001-05-02 11:30 ` Alan Cox
2001-05-02 12:53 ` martin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010502145305.B6889@kungen.fatbob.nu \
--to=martin@fatbob.nu \
--cc=fluido@fluido.as \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®