From: James Washer <washer@sequent.com>
To: linux-kernel@vger.kernel.org
Subject: scan_scsis limits LUNs to max_scsi_luns... is this what we want?
Date: Thu, 3 May 2001 16:54:01 -0700 (PDT) [thread overview]
Message-ID: <200105032354.QAA18993@crg8.sequent.com> (raw)
In the routine scan_scsis(), The following code would appear to limit
the number of luns a given apapter can use to max_scsi_luns, as opposed
to the limit the low-level driver passed in the Scsi_Host structure.
Is that the behaviour we want? or should the '<' become a '>' in the ternary,
thereby scanning the greater of the passed max_lun or the system max_scsi_luns.
It seems to me that if a low level driver passes a large number of luns,
the midlayer should accept that value.
Of course, the use of the CONFIG_SCSI_MULTI_LUN #define would lead me to
believe that the kernel does indeed want to limit the number of luns probed
to the lesser of the two values... but why??
max_dev_lun = (max_scsi_luns < shpnt->max_lun ?
max_scsi_luns : shpnt->max_lun);
sparse_lun = 0;
for (lun = 0; lun < max_dev_lun; ++lun) {
if (!scan_scsis_single(channel, order_dev, lun, &max_dev_lun,
&sparse_lun, &SDpnt, shpnt,
scsi_result)
&& !sparse_lun) break;
}
--
+==============================================================+
| James W Washer IBM NUMA-Q Service KG7HH(US) M0BOR(UK) |
| |
| 15450 SW Koll Pkwy |
| MS RHE2-501 |
| Beaverton, OR 97006 |
| |
| 1-800-854-9969 1-503-578-3171(direct line) |
| washer@us.ibm.com |
+==============================================================+
reply other threads:[~2001-05-03 23:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200105032354.QAA18993@crg8.sequent.com \
--to=washer@sequent.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®