mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Taral <taral@taral.net>
To: linux-kernel@vger.kernel.org
Subject: tty kill character handling problems
Date: Sat, 12 May 2001 02:33:07 -0500	[thread overview]
Message-ID: <20010512023307.A9339@taral.net> (raw)

I think the current echok/echoke/echoe handling is wrong. The following
patch should fix the problem, unless I've totally misunderstood this...

--- linux/drivers/char/n_tty.c.orig	Fri May 11 21:45:48 2001
+++ linux/drivers/char/n_tty.c	Fri May 11 22:00:52 2001
@@ -352,7 +352,7 @@
 			spin_unlock_irqrestore(&tty->read_lock, flags);
 			return;
 		}
-		if (!L_ECHOK(tty) || !L_ECHOKE(tty) || !L_ECHOE(tty)) {
+		if (!L_ECHOKE(tty)) {
 			spin_lock_irqsave(&tty->read_lock, flags);
 			tty->read_cnt -= ((tty->read_head - tty->canon_head) &
 					  (N_TTY_BUF_SIZE - 1));

-- 
Taral <taral@taral.net>
Please use PGP/GPG encryption to send me mail.
"Any technology, no matter how primitive, is magic to those who don't
understand it." -- Florence Ambrose

                 reply	other threads:[~2001-05-12  7:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010512023307.A9339@taral.net \
    --to=taral@taral.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®