From: Andi Kleen <ak@suse.de>
To: mostrows@speakeasy.net
Cc: Marcell GAL <cell@sch.bme.hu>,
linux-kernel@vger.kernel.org, paulus@samba.org,
"David S. Miller" <davem@redhat.com>
Subject: Re: Scheduling in interrupt BUG. [Patch]
Date: Mon, 14 May 2001 22:45:08 +0200 [thread overview]
Message-ID: <20010514224508.A3960@gruyere.muc.suse.de> (raw)
In-Reply-To: <3AFFBF14.7D7BAB01@sch.bme.hu> <15103.53345.869090.593925@slug.watson.ibm.com>
In-Reply-To: <15103.53345.869090.593925@slug.watson.ibm.com>; from mostrows@us.ibm.com on Mon, May 14, 2001 at 08:32:33AM -0400
On Mon, May 14, 2001 at 08:32:33AM -0400, Michal Ostrowski wrote:
> Having looked at the code for locking sockets I am concerned that the
> locking procedures for tcp may be wrong. __release_sock releases the
> socket spinlock before calling sk->backlog_rcv() (== tcp_v4_do_rcv),
> however the comments at the top of tcp_v4_do_rcv() assert that the
> socket's spinlock is held (which is definitely not the case).
>
> Anybody care to comment on this?
Looks ok for me.
The user socket lock (lock.users>0) is held while __release_sock runs,
which is also sufficient to protect it as all new packets will go into backlog.
The spinlock comment only applies to bottom halves.
-Andi
next prev parent reply other threads:[~2001-05-14 20:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-14 11:18 Scheduling in interrupt BUG Marcell GAL
2001-05-14 12:32 ` Scheduling in interrupt BUG. [Patch] Michal Ostrowski
2001-05-14 20:21 ` Marcell Gal
2001-05-14 20:24 ` Michal Ostrowski
2001-05-14 20:45 ` Andi Kleen [this message]
2001-05-14 13:04 ` Scheduling in interrupt BUG Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010514224508.A3960@gruyere.muc.suse.de \
--to=ak@suse.de \
--cc=cell@sch.bme.hu \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mostrows@speakeasy.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®