mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrzej Krzysztofowicz <ankry@pg.gda.pl>
To: simon.geard@ntlworld.com (Simon Geard)
Cc: linux-kernel@vger.kernel.org
Subject: Re: make xconfig with tcl/tk 8.3 - the patches
Date: Thu, 17 May 2001 11:57:18 +0200 (MET DST)	[thread overview]
Message-ID: <200105170957.LAA19756@sunrise.pg.gda.pl> (raw)
In-Reply-To: <01051710052900.01236@Granville> from "Simon Geard" at May 17, 2001 10:05:29 AM

"Simon Geard wrote:"
> 
> Re my previous message on this subject, the patch files are attached.
> 
> They can also be found at my web site:
> 
> http://homepage.ntlworld.com/whiteowl/kernel

Unfortunately your patches break with older tk:

Error in startup script: couldn't compile regular expression pattern: nested
*?+
    while executing
"regexp {([0-9A-Za-z_]+)="(.*?)"} $line foo var value"
    (procedure "read_config" line 18)
    invoked from within
"read_config $defaults"
    (file "scripts/kconfig.tk" line 21611)
make: *** [xconfig] Error 1

I've checked tk-8.0 and 8.0.3.

Some other comments:
- please generate patches as universal diff (-uNr options for diff are
  preferred)
- please follow indentation rules used in a file you modify.
  {header,tail}.tk are tab-indented, not spaces.

Regards
    Andrzej


      reply	other threads:[~2001-05-17  9:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-17  9:05 Simon Geard
2001-05-17  9:57 ` Andrzej Krzysztofowicz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200105170957.LAA19756@sunrise.pg.gda.pl \
    --to=ankry@pg.gda.pl \
    --cc=ankry@green.mif.pg.gda.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simon.geard@ntlworld.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®