From: Andrzej Krzysztofowicz <ankry@green.mif.pg.gda.pl>
To: kaos@ocs.com.au (Keith Owens)
Cc: jgarzik@mandrakesoft.com (Jeff Garzik),
ankry@green.mif.pg.gda.pl (Andrzej Krzysztofowicz),
alan@lxorguk.ukuu.org.uk (Alan Cox),
linux-kernel@vger.kernel.org (kernel list)
Subject: Re: [PATCH] 2.4.4-ac11 network drivers cleaning
Date: Sun, 20 May 2001 15:35:35 +0200 (CEST) [thread overview]
Message-ID: <200105201335.PAA03927@green.mif.pg.gda.pl> (raw)
In-Reply-To: <12098.990324222@ocs3.ocs-net> from "Keith Owens" at May 20, 2001 12:03:42 PM
>
> On Sat, 19 May 2001 17:58:49 -0400,
> Jeff Garzik <jgarzik@mandrakesoft.com> wrote:
> >Finally, I don't know if I mentioned this earlier, but to be complete
> >and optimal, version strings should be a single variable 'version', such
> >that it can be passed directly to printk like
> >
> > printk(version);
>
> Nit pick. That has random side effects if version contains any '%'
> characters. Make it
It should not. I see no reason for a literal % in the version string.
>
> printk("%s\n", version);
>
> Not quite as optimal but safer.
It is simpler to remove the %s from version. I don't think any of them
require it. If one add a % he should know what he is doing.
--
=======================================================================
Andrzej M. Krzysztofowicz ankry@mif.pg.gda.pl
tel. (0-58) 347 14 61
Wydz.Fizyki Technicznej i Matematyki Stosowanej Politechniki Gdanskiej
prev parent reply other threads:[~2001-05-20 13:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-19 21:41 Andrzej Krzysztofowicz
2001-05-19 21:58 ` Jeff Garzik
2001-05-20 2:03 ` Keith Owens
2001-05-20 2:22 ` Jeff Garzik
2001-05-20 19:43 ` Alan Cox
2001-05-20 13:35 ` Andrzej Krzysztofowicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200105201335.PAA03927@green.mif.pg.gda.pl \
--to=ankry@green.mif.pg.gda.pl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@mandrakesoft.com \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®