From: Andi Kleen <ak@suse.de>
To: "David S. Miller" <davem@redhat.com>
Cc: Andi Kleen <ak@suse.de>, Andrea Arcangeli <andrea@suse.de>,
Andrew Morton <andrewm@uow.edu.au>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Richard Henderson <rth@twiddle.net>,
linux-kernel@vger.kernel.org
Subject: Re: alpha iommu fixes
Date: Mon, 21 May 2001 13:08:35 +0200 [thread overview]
Message-ID: <20010521130835.A3910@gruyere.muc.suse.de> (raw)
In-Reply-To: <20010521105944.H30738@athlon.random> <15112.55709.565823.676709@pizda.ninka.net> <20010521112357.A1718@gruyere.muc.suse.de> <15112.57377.723591.710628@pizda.ninka.net> <20010521114216.A1968@gruyere.muc.suse.de> <15112.59192.613218.796909@pizda.ninka.net> <20010521122753.A2507@gruyere.muc.suse.de> <15112.61258.251051.960811@pizda.ninka.net> <20010521124225.A3417@gruyere.muc.suse.de> <15112.62483.731973.549006@pizda.ninka.net>
In-Reply-To: <15112.62483.731973.549006@pizda.ninka.net>; from davem@redhat.com on Mon, May 21, 2001 at 03:55:15AM -0700
On Mon, May 21, 2001 at 03:55:15AM -0700, David S. Miller wrote:
> The original claim is that the situation was not handled at all. All
> I'm trying to say is simply that the net stack does check via
> illegal_highdma() the condition you stated was not being checked at
> all. To me it sounded like you were claiming that HIGHMEM pages went
> totally unchecked through device transmit, and that is totally untrue.
Yes I was wrong on this one, but after looking at the acenic I think
the current solution is not very nice to driver authors.
>
> If you were trying to point out the problem with what the Acenic
> driver is doind, just state that next time ok? :-)
It's more a generic problem with PCI DMA API, acenic just happens to
be the clearest victim of it @)
> Plainly, I'm going to be highly reluctant to make changes to the PCI
> dma API in 2.4.x It is already hard enough to get all the PCI drivers
> in line and using it. Suggesting this kind of change is similar to
> saying "let's change the arguments to request_irq()". We would do it
> to fix a true "people actually hit this" kind of bug, of course. Yet
> we would avoid it at all possible costs due to the disruption this
> would cause.
How about a new function (pci_nonrepresentable_address() or whatever)
that returns true when page cache contains pages that are not representable
physically as void *. On IA32 it would return true only if CONFIG_PAE is
true and there is memory >4GB.
Then the network driver could do
if (!pci_nonrepresentable_address())
dev->features |= NETIF_F_HIGHDMA;
[in theory it would be possible to push it up into dev.c to avoid
bounces for highmem memory <4GB, but I don't want to teach such details
to the generic layer]
DAC support would be the next step, not necessarily one for 2.4, but perhaps
one that could be backported from 2.5 at some point.
-Andi
next prev parent reply other threads:[~2001-05-21 11:09 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-18 17:46 Ivan Kokshaysky
2001-05-19 2:34 ` Tom Vier
2001-05-19 10:48 ` Ivan Kokshaysky
2001-05-19 20:58 ` Tom Vier
2001-05-19 13:55 ` Andrea Arcangeli
2001-05-19 19:11 ` Ivan Kokshaysky
2001-05-20 2:40 ` Andrea Arcangeli
2001-05-20 12:12 ` Ivan Kokshaysky
2001-05-20 13:40 ` Andrea Arcangeli
2001-05-20 14:23 ` Gérard Roudier
[not found] ` <3B07AF49.5A85205F@uow.edu.au>
2001-05-20 13:49 ` Andrea Arcangeli
2001-05-20 14:05 ` Andrew Morton
2001-05-20 14:33 ` Andrea Arcangeli
2001-05-21 1:01 ` David S. Miller
2001-05-21 1:47 ` Andrea Arcangeli
2001-05-21 7:05 ` David S. Miller
2001-05-21 8:59 ` Andrea Arcangeli
2001-05-21 9:50 ` Gerd Knorr
2001-05-21 9:02 ` David S. Miller
2001-05-21 9:23 ` Andi Kleen
2001-05-21 9:30 ` David S. Miller
2001-05-21 9:42 ` Andi Kleen
2001-05-21 10:02 ` Andrea Arcangeli
2001-05-21 10:17 ` Alan Cox
2001-05-21 10:00 ` David S. Miller
2001-05-21 10:27 ` Andi Kleen
2001-05-21 22:22 ` Jens Axboe
2001-05-21 10:34 ` David S. Miller
2001-05-21 10:42 ` Andi Kleen
2001-05-21 10:55 ` David S. Miller
2001-05-21 11:08 ` Andi Kleen [this message]
2001-05-21 11:36 ` David S. Miller
2001-05-21 11:41 ` Andi Kleen
2001-05-21 9:56 ` Andrea Arcangeli
2001-05-21 10:19 ` David S. Miller
2001-05-21 11:00 ` Andrea Arcangeli
2001-05-21 11:04 ` David S. Miller
2001-05-21 11:27 ` Andrea Arcangeli
2001-05-21 12:16 ` Peter Rival
2001-05-22 11:12 ` Chris Wedgwood
2001-05-22 17:51 ` Jonathan Lundell
2001-05-21 10:11 ` David S. Miller
2001-05-21 10:50 ` Andrea Arcangeli
2001-05-21 10:59 ` David S. Miller
2001-05-21 11:19 ` Andrea Arcangeli
2001-05-21 11:51 ` Ivan Kokshaysky
2001-05-21 17:53 ` Richard Henderson
2001-05-22 0:56 ` Andrea Arcangeli
2001-05-22 14:29 ` Andrea Arcangeli
2001-05-22 14:44 ` Ivan Kokshaysky
2001-05-22 15:00 ` Andrea Arcangeli
2001-05-22 20:28 ` Richard Henderson
2001-05-22 20:40 ` Jeff Garzik
2001-05-22 20:52 ` Andrea Arcangeli
2001-05-22 20:57 ` Richard Henderson
2001-05-22 21:09 ` Alan Cox
2001-05-22 21:08 ` Alan Cox
2001-05-22 20:48 ` Jonathan Lundell
2001-05-22 21:02 ` Richard Henderson
2001-05-22 21:10 ` Alan Cox
2001-05-22 21:17 ` Jonathan Lundell
2001-05-22 21:24 ` Alan Cox
2001-05-22 21:34 ` Jonathan Lundell
2001-05-22 15:18 ` Andrea Arcangeli
2001-05-22 15:55 ` Ivan Kokshaysky
2001-05-22 16:06 ` Andrea Arcangeli
2001-05-22 13:22 ` Andrea Arcangeli
2001-05-21 13:55 ` Jonathan Lundell
2001-05-21 14:17 ` Ivan Kokshaysky
2001-05-21 15:47 ` Jonathan Lundell
2001-05-20 16:18 ` Andrea Arcangeli
2001-05-20 16:21 ` Andrew Morton
2001-05-20 16:44 ` Andrea Arcangeli
2001-05-20 16:54 ` Andrew Morton
2001-05-20 17:12 ` Andrea Arcangeli
2001-05-21 1:07 ` David S. Miller
2001-05-21 1:37 ` Andrea Arcangeli
2001-05-21 6:53 ` David S. Miller
2001-05-21 7:59 ` Alan Cox
2001-05-21 8:06 ` Chris Wedgwood
2001-05-21 8:09 ` David S. Miller
2001-05-21 8:09 ` Alan Cox
2001-05-23 0:05 ` Albert D. Cahalan
2001-05-22 13:11 ` Pavel Machek
2001-05-22 23:02 ` David S. Miller
2001-05-20 17:16 ` Jeff Garzik
2001-05-20 17:37 ` Andrea Arcangeli
2001-05-21 1:00 ` David S. Miller
2001-05-21 7:47 ` Alan Cox
2001-05-21 7:53 ` David S. Miller
2001-05-21 8:03 ` Alan Cox
2001-05-21 8:11 ` David S. Miller
2001-05-21 1:03 ` David S. Miller
2001-05-21 1:58 ` Richard Henderson
2001-05-20 1:11 ` Richard Henderson
2001-05-20 12:05 ` Ivan Kokshaysky
2001-05-21 0:37 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010521130835.A3910@gruyere.muc.suse.de \
--to=ak@suse.de \
--cc=andrea@suse.de \
--cc=andrewm@uow.edu.au \
--cc=davem@redhat.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®