From: Andi Kleen <ak@suse.de>
To: "David Gordon (LMC)" <David.Gordon@ericsson.ca>
Cc: Andi Kleen <ak@suse.de>,
"David Gordon (LMC)" <David.Gordon@lmc.ericsson.se>,
linux-kernel@vger.kernel.org,
"Ibrahim Haddad (LMC)" <Ibrahim.Haddad@lmc.ericsson.se>
Subject: Re: IPv6 implementation in kernel 2.4.4 oopses
Date: Wed, 23 May 2001 22:21:37 +0200 [thread overview]
Message-ID: <20010523222137.A874@gruyere.muc.suse.de> (raw)
In-Reply-To: <3B0C0D0B.2010101@lmc.ericsson.se> <20010523214654.A779@gruyere.muc.suse.de> <3B0C15F3.1070408@lmc.ericsson.se>
In-Reply-To: <3B0C15F3.1070408@lmc.ericsson.se>; from David.Gordon@ericsson.ca on Wed, May 23, 2001 at 03:56:35PM -0400
On Wed, May 23, 2001 at 03:56:35PM -0400, David Gordon (LMC) wrote:
> >>EIP; c0237bc4 <ipv6_addr_type+4/e0> <=====
>
> What exactly was the problem that was fixed in the latest pre kernel ?
A coding mistake was fixed.
Here is the patch if you're interested (cut'n'pasted so not applicable)
RCS file: /cvs/linux/net/ipv6/ndisc.c,v
retrieving revision 1.49
retrieving revision 1.50
diff -u -u -r1.49 -r1.50
--- net/ipv6/ndisc.c 2001/05/03 07:02:47 1.49
+++ net/ipv6/ndisc.c 2001/05/05 01:59:27 1.50
@@ -382,7 +382,7 @@
int send_llinfo;
len = sizeof(struct icmp6hdr) + sizeof(struct in6_addr);
- send_llinfo = dev->addr_len && ipv6_addr_type(saddr) != IPV6_ADDR_ANY;
+ send_llinfo = dev->addr_len && saddr && ipv6_addr_type(saddr) != IPV6_AD
DR_ANY;
if (send_llinfo)
len += NDISC_OPT_SPACE(dev->addr_len);
next prev parent reply other threads:[~2001-05-23 20:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-23 19:18 David Gordon (LMC)
2001-05-23 19:46 ` Andi Kleen
2001-05-23 19:56 ` David Gordon (LMC)
2001-05-23 20:21 ` Andi Kleen [this message]
2001-05-24 0:02 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010523222137.A874@gruyere.muc.suse.de \
--to=ak@suse.de \
--cc=David.Gordon@ericsson.ca \
--cc=David.Gordon@lmc.ericsson.se \
--cc=Ibrahim.Haddad@lmc.ericsson.se \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®