mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rasmus Andersen <rasmus@jaquet.dk>
To: gadio@netvision.net.il
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] __idetape_kmalloc_stage return code check in ide-tape.c (244-ac16)
Date: Fri, 25 May 2001 22:24:19 +0200	[thread overview]
Message-ID: <20010525222419.G851@jaquet.dk> (raw)

Hi.

This trivial patch adds a kmalloc check to ide-tape.c::
idetape_onstream_read_back_buffer as per the Stanford team's report
way back. It applies against 244ac16.

Reading the code I was not sure if it was OK to just return
or more should be done. Please sanity check this.

--- linux-244-ac11-clean/drivers/ide/ide-tape.c	Sat May 19 21:06:35 2001
+++ linux-244-ac11/drivers/ide/ide-tape.c	Sun May 20 14:58:44 2001
@@ -3472,6 +3472,11 @@
 	printk(KERN_INFO "ide-tape: %s: reading back %d frames from the drive's internal buffer\n", tape->name, frames);
 	for (i = 0; i < frames; i++) {
 		stage = __idetape_kmalloc_stage(tape, 0, 0);
+                if(!stage) {
+                        printk(KERN_WARNING "(idetape:) Failed to allocate memory for buffer\n");
+                        return;
+                }
+                        
 		if (!first)
 			first = stage;
 		aux = stage->aux;
-- 
Regards,
        Rasmus(rasmus@jaquet.dk)

'Xenix is the pinnacle of modern UNIX design, and will be used for many
years to come' -Xenix OS API manual 

                 reply	other threads:[~2001-05-25 20:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010525222419.G851@jaquet.dk \
    --to=rasmus@jaquet.dk \
    --cc=gadio@netvision.net.il \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®