From: Masaru Kawashima <masaruk@gol.com>
To: Ville Herva <vherva@mail.niksula.cs.hut.fi>
Cc: linux-kernel@vger.kernel.org
Subject: Re: initrd oops; still happens with 2.4.5ac2
Date: Mon, 28 May 2001 18:02:54 +0900 [thread overview]
Message-ID: <20010528180254.380908d8.masaruk@gol.com> (raw)
In-Reply-To: <20010528102551.N11981@niksula.cs.hut.fi>
In-Reply-To: <20010526225825.A31713@lightning.swansea.linux.org.uk> <20010527192650.H11981@niksula.cs.hut.fi> <20010528001220.M11981@niksula.cs.hut.fi> <20010528102551.N11981@niksula.cs.hut.fi>
On Mon, 28 May 2001 10:25:51 +0300
Ville Herva <vherva@mail.niksula.cs.hut.fi> wrote:
> The oops call trace seems to be the same as in
>
> http://marc.theaimsgroup.com/?l=linux-kernel&m=99079948404775&w=2
>
> Any ideas?
Did you try the patch posted by Go Taniguchi <go@turbolinux.co.jp>?
Following is the copy of his message and the patch itself.
--
Masaru Kawashima
=====================================================================
From: Go Taniguchi <go@turbolinux.co.jp>
To: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH]initrd unmount problem
Date: Mon, 28 May 2001 13:26:20 +0900
Sender: linux-kernel-owner@vger.kernel.org
Organization: Turbolinx Inc.
X-Mailer: Mozilla 4.75 [ja] (X11; U; Linux 2.2.18-10 i686)
Hi,
It seems that ioctl_by_bdev() in fs/block_dev.c has a problem.
When initrd is unmounted it can cause OOPS.
This problem occurs in recent ac patches.
May be vanilla too.
change_root() in fs/super.c calls ioctl_by_bdev() in
fs/block_dev.c which does not set inode_fake.i_bdev.
But ioctl of ramdisk (rd_ioctl() in rd.c) accesses to
i_bdev->bd_openers of the inode and which causes OOPS.
I attach the patch.
- GO!
--- linux/fs/block_dev.c.orig Mon May 28 12:40:12 2001
+++ linux/fs/block_dev.c Mon May 28 12:40:12 2001
@@ -602,6 +602,7 @@
if (!bdev->bd_op->ioctl)
return -EINVAL;
inode_fake.i_rdev=rdev;
+ inode_fake.i_bdev=bdev;
init_waitqueue_head(&inode_fake.i_wait);
set_fs(KERNEL_DS);
res = bdev->bd_op->ioctl(&inode_fake, NULL, cmd, arg);
next prev parent reply other threads:[~2001-05-28 9:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-26 21:58 Linux 2.4.5-ac1 Alan Cox
2001-05-27 16:26 ` [OOPS] " Ville Herva
2001-05-27 21:12 ` initrd oops [was Re: Linux 2.4.5-ac1] Ville Herva
2001-05-28 7:25 ` initrd oops; still happens with 2.4.5ac2 Ville Herva
2001-05-28 8:51 ` Ville Herva
2001-05-28 9:02 ` Masaru Kawashima [this message]
2001-05-28 10:05 ` initrd oops with 2.4.5ac2: FIXED by Kawashima (the other oops may remain) Ville Herva
2001-05-28 10:28 ` initrd oops with 2.4.5ac2: Tthe other oops remains (one fixed) Ville Herva
2001-05-28 10:48 ` initrd oops with 2.4.5ac2: megaraid OOPSes Ville Herva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010528180254.380908d8.masaruk@gol.com \
--to=masaruk@gol.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vherva@mail.niksula.cs.hut.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®