From: Dawson Engler <engler@csl.Stanford.EDU>
To: dwmw2@infradead.org (David Woodhouse)
Cc: linux-kernel@vger.kernel.org, mc@CS.Stanford.EDU
Subject: Re: [CHECKER] 2.4.5-ac4 non-init functions calling init functions
Date: Wed, 30 May 2001 16:01:03 -0700 (PDT) [thread overview]
Message-ID: <200105302301.QAA08564@csl.Stanford.EDU> (raw)
In-Reply-To: <26484.991258403@redhat.com> from "David Woodhouse" at May 30, 2001 10:33:23 PM
> > drivers/mtd/docprobe.c:195:DoC_Probe: ERROR:INIT: non-init fn
> > 'DoC_Probe' calling init fn 'doccheck'
>
> Strictly speaking, not actually a bug. DoC_Probe() itself is only ever
> called from __init code. But it's probably not worth trying to make the
> checker notice that situation - I've fixed it anyway by making DoC_Probe()
> __init too, which saves a bit more memory. Thanks.
It's a space/performance bug, though, right? From the original mail:
1. The best case: the caller should actually be an __init function
as well. This is a performance bug since it won't be freed.
next prev parent reply other threads:[~2001-05-30 23:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-30 20:08 Dawson Engler
2001-05-30 21:33 ` David Woodhouse
2001-05-30 22:00 ` Oliver Xymoron
2001-05-30 23:01 ` Dawson Engler [this message]
2001-05-31 7:09 ` David Woodhouse
2001-05-30 21:40 ` Harald Welte
2001-05-30 23:08 ` [PATCH] " Petr Vandrovec
2001-05-31 21:38 ` Kai Germaschewski
2001-05-31 22:06 ` Dawson Engler
2001-06-01 7:48 ` Geert Uytterhoeven
2001-06-01 18:09 Khachaturov, Vassilii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200105302301.QAA08564@csl.Stanford.EDU \
--to=engler@csl.stanford.edu \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mc@CS.Stanford.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®