From: Andrzej Krzysztofowicz <kufel!ankry@green.mif.pg.gda.pl>
To: kufel!caldera.de!Marcus.Meissner@green.mif.pg.gda.pl (Marcus Meissner)
Cc: kufel!lxorguk.ukuu.org.uk!alan@green.mif.pg.gda.pl (Alan Cox),
kufel!vger.kernel.org!linux-kernel@green.mif.pg.gda.pl
Subject: Re: PATCH: cs4232 isapnp support
Date: Fri, 1 Jun 2001 22:54:57 +0200 (CEST) [thread overview]
Message-ID: <200106012054.WAA01139@kufel.dom> (raw)
In-Reply-To: <20010601193533.A14769@caldera.de> from "Marcus Meissner" at cze 01, 2001 07:35:33
Hi,
> This adds ISAPnP support to cs4232.c.
[...]
> diff -u -r1.10 cs4232.c
> --- drivers/sound/cs4232.c 2001/05/27 18:06:09 1.10
> +++ drivers/sound/cs4232.c 2001/06/01 17:26:52
[...]
> @@ -318,22 +325,92 @@
> static int __initdata mpuirq = -1;
> static int __initdata synthio = -1;
> static int __initdata synthirq = -1;
> -
> +static int __initdata isapnp = 1;
According to the comment in include/linux/init.h these are incorrect:
* For initialized data:
* You should insert __initdata between the variable name and equal
* sign followed by value, e.g.:
*
* static int init_variable __initdata = 0;
* static char linux_logo[] __initdata = { 0x32, 0x36, ... };
*
AFAIR, moving the __initdata cause problems with some gcc versions.
Andrzej
prev parent reply other threads:[~2001-06-01 22:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-01 17:35 Marcus Meissner
2001-06-01 20:54 ` Andrzej Krzysztofowicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200106012054.WAA01139@kufel.dom \
--to=kufel!ankry@green.mif.pg.gda.pl \
--cc=kufel!caldera.de!Marcus.Meissner@green.mif.pg.gda.pl \
--cc=kufel!lxorguk.ukuu.org.uk!alan@green.mif.pg.gda.pl \
--cc=kufel!vger.kernel.org!linux-kernel@green.mif.pg.gda.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®