mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Kravetz <mkravetz@sequent.com>
To: linux-kernel@vger.kernel.org
Subject: reschedule_idle changes in ac kernels
Date: Mon, 4 Jun 2001 16:08:37 -0700	[thread overview]
Message-ID: <20010604160837.B15640@w-mikek2.des.sequent.com> (raw)

I just noticed the changes to reschedule_idle() in the 2.4.5-ac
kernel.  I suspect these are the changes made for:

o       Fix off by one on real time pre-emption in scheduler

I'm curious if anyone has ran any benchmarks before and after
applying this fix.

The reason I ask is that during the development of my multi-queue
scheduler, I 'accidently' changed reschedule_idle code to trigger
a preemption if preemption_goodness() was greater than 0, as
opposed to greater than 1.  I believe this is the same change made
to the ac kernel.  After this change, we saw a noticeable drop in
performance for some benchmarks.

The drop in performance I saw could have been the result of a
combination of the change, and my multi-queue scheduler.  However,
in any case aren't we now going to trigger more preemptions?

I understand that we need to make the fig to get the realtime
semantics correct,  but we also need to be aware of performance in
the non-realtime case.

-- 
Mike Kravetz                                 mkravetz@sequent.com
IBM Linux Technology Center

             reply	other threads:[~2001-06-04 23:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-04 23:08 Mike Kravetz [this message]
2001-06-05  0:25 ` Nigel Gamble
2001-06-05 21:26   ` Mike Kravetz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010604160837.B15640@w-mikek2.des.sequent.com \
    --to=mkravetz@sequent.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®