From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: Tom Vier <tmv5@home.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
"Maciej W. Rozycki" <macro@ds2.pg.gda.pl>,
linux-kernel@vger.kernel.org
Subject: [patch] Re: Linux 2.4.5-ac6
Date: Mon, 4 Jun 2001 21:08:35 +0400 [thread overview]
Message-ID: <20010604210835.A2907@jurassic.park.msu.ru> (raw)
In-Reply-To: <20010601120105.A1356@lightning.swansea.linux.org.uk> <20010601222709.A566@zero>
In-Reply-To: <20010601222709.A566@zero>; from tmv5@home.com on Fri, Jun 01, 2001 at 10:27:09PM -0400
On Fri, Jun 01, 2001 at 10:27:09PM -0400, Tom Vier wrote:
> > o Fix mmap cornercase (Maciej Rozycki)
>
> when i try running osf/1 netscape on alpha, mmap of libXmu fails. works fine
> on -ac5.
Indeed. Netscape is essentially 32 bit application, so probably
it treats TASK_UNMAPPED_BASE (0x20000000000) as failure.
A tad more respect of specified address fixes that.
Also small fix for endless compile warnings with gcc 3.0 on
alpha (`struct mm_struct' declared inside parameter list).
Ivan.
--- 2.4.5-ac7/mm/mmap.c Mon Jun 4 14:19:02 2001
+++ linux/mm/mmap.c Mon Jun 4 19:22:31 2001
@@ -404,10 +404,13 @@ static inline unsigned long arch_get_unm
if (addr) {
addr = PAGE_ALIGN(addr);
- vma = find_vma(current->mm, addr);
- if (TASK_SIZE - len >= addr &&
- (!vma || addr + len <= vma->vm_start))
- return addr;
+ for (vma = find_vma(current->mm, addr); ; vma = vma->vm_next) {
+ if (TASK_SIZE - len < addr)
+ break;
+ if (!vma || addr + len <= vma->vm_start)
+ return addr;
+ addr = vma->vm_end;
+ }
}
addr = PAGE_ALIGN(TASK_UNMAPPED_BASE);
--- 2.4.5-ac7/include/linux/binfmts.h Mon Jun 4 14:19:00 2001
+++ linux/include/linux/binfmts.h Mon Jun 4 20:24:50 2001
@@ -32,6 +32,9 @@ struct linux_binprm{
unsigned long loader, exec;
};
+/* Forward declaration */
+struct mm_struct;
+
/*
* This structure defines the functions that are used to load the binary formats that
* linux accepts.
next prev parent reply other threads:[~2001-06-04 17:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-01 11:01 Alan Cox
2001-06-01 11:28 ` Alexander Viro
2001-06-01 11:52 ` Alan Cox
2001-06-01 12:23 ` Keith Owens
2001-06-02 2:27 ` Tom Vier
2001-06-04 10:16 ` Maciej W. Rozycki
2001-06-04 17:08 ` Ivan Kokshaysky [this message]
2001-06-05 15:11 ` [patch] " Maciej W. Rozycki
2001-06-05 17:41 ` Ivan Kokshaysky
2001-06-05 18:32 ` Maciej W. Rozycki
2001-06-06 5:37 ` Ivan Kokshaysky
2001-06-06 13:09 ` Maciej W. Rozycki
2001-06-06 14:49 ` Jeff Garzik
2001-06-06 17:26 ` Maciej W. Rozycki
2001-06-07 17:48 ` Ivan Kokshaysky
2001-06-07 18:31 ` Maciej W. Rozycki
2001-06-08 10:18 ` jlnance
2001-06-08 17:06 ` Gerhard Mack
2001-06-08 14:18 ` Ivan Kokshaysky
2001-06-07 17:20 ` Ivan Kokshaysky
2001-06-07 18:28 ` Maciej W. Rozycki
2001-06-08 14:16 ` Ivan Kokshaysky
2001-06-08 16:08 ` Maciej W. Rozycki
2001-06-08 17:23 ` Ivan Kokshaysky
2001-06-09 10:14 ` Ivan Kokshaysky
2001-06-09 18:46 ` Tom Vier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010604210835.A2907@jurassic.park.msu.ru \
--to=ink@jurassic.park.msu.ru \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@ds2.pg.gda.pl \
--cc=tmv5@home.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®