Re: Break 2.4 VM in five easy steps

[Pavel Machek <pavel@suse.cz>]

Hi!

> If this solves your problem, use it; if your name is Linus or Alan,
> ignore or do it right please.

Well I guess you should do CONDITIONAL_SCHEDULE (if it is not defined
as macro, do if (current->need_resched) schedule()).

That modulo is likely slower than dereference.

> diff -u -r1.1 -r1.2
> --- linux-hack/mm/filemap.c     2001/06/06 21:16:28     1.1
> +++ linux-hack/mm/filemap.c     2001/06/07 08:57:52     1.2
> @@ -2599,6 +2599,11 @@
>                 char *kaddr;
>                 int deactivate = 1;
>  
> +               /* bernd-hack: give other processes a chance to run */
> +               if (count % 256 == 0) {
> +                       schedule();
> +               }
> +
>                 /*
>                  * Try to find the page in the cache. If it isn't there,
>                  * allocate a free page.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.0.4 (GNU/Linux)
> Comment: For info see http://www.gnupg.org
> 
> iD8DBQE7H1tb/FmLrNfLpjMRAguAAJ0fYInFbAa6LjFC/CWZbRPQxzZwrwCeNqT0
> /Kod15Nx7AzaM4v0WhOgp88=
> =pyr6
> -----END PGP SIGNATURE-----
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Philips Velo 1: 1"x4"x8", 300gram, 60, 12MB, 40bogomips, linux, mutt,
details at http://atrey.karlin.mff.cuni.cz/~pavel/velo/index.html.