mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Dieter Nützel" <Dieter.Nuetzel@hamburg.de>
To: Alan Cox <laughing@shared-source.org>
Cc: Andrew Morton <andrewm@uow.edu.au>,
	Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: Linux-2.4.5-ac17 --- Where is the  truncate_inode_pages speedup patch?
Date: Fri, 22 Jun 2001 00:52:10 +0200	[thread overview]
Message-ID: <20010621223153Z265268-17720+6468@vger.kernel.org> (raw)

Hello Alan,

I use it all the time and it is not pre6 stuff related...:-)

Thanks,
	Dieter

--- linux/mm/filemap.c    Mon May 28 13:31:49 2001
+++ linux/mm/filemap.c     Mon Jun 11 23:31:08 2001
@@ -230,17 +230,17 @@
                unsigned long offset;
 
                page = list_entry(curr, struct page, list);
-               curr = curr->next;
                offset = page->index;
 
                /* Is one of the pages to truncate? */
                if ((offset >= start) || (*partial && (offset + 1) == start)) 
{
+                       list_del(head);
+                       list_add(head, curr);
                        if (TryLockPage(page)) {
                                page_cache_get(page);
                                spin_unlock(&pagecache_lock);
                                wait_on_page(page);
-                               page_cache_release(page);
-                               return 1;
+                               goto out_restart;
                        }
                        page_cache_get(page);
                        spin_unlock(&pagecache_lock);
@@ -252,11 +252,15 @@
                                truncate_complete_page(page);
 
                        UnlockPage(page);
-                       page_cache_release(page);
-                       return 1;
+                       goto out_restart;
                }
+               curr = curr->next;
        }
        return 0;
+out_restart:
+       page_cache_release(page);
+       spin_lock(&pagecache_lock);
+       return 1;
 }
 
 
@@ -273,15 +277,19 @@
 {
        unsigned long start = (lstart + PAGE_CACHE_SIZE - 1) >> 
PAGE_CACHE_SHIFT;
        unsigned partial = lstart & (PAGE_CACHE_SIZE - 1);
+       int complete;
 
-repeat:
        spin_lock(&pagecache_lock);
-       if (truncate_list_pages(&mapping->clean_pages, start, &partial))
-               goto repeat;
-       if (truncate_list_pages(&mapping->dirty_pages, start, &partial))
-               goto repeat;
-       if (truncate_list_pages(&mapping->locked_pages, start, &partial))
-               goto repeat;
+       do {
+               complete = 1;
+               while (truncate_list_pages(&mapping->clean_pages, start, 
&partial))
+                       complete = 0;
+               while (truncate_list_pages(&mapping->dirty_pages, start, 
&partial))
+                       complete = 0;
+               while (truncate_list_pages(&mapping->locked_pages, start, 
&partial))
+                       complete = 0;
+       } while (!complete);
+       /* Traversed all three lists without dropping the lock */
        spin_unlock(&pagecache_lock);
 }

                 reply	other threads:[~2001-06-21 22:32 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010621223153Z265268-17720+6468@vger.kernel.org \
    --to=dieter.nuetzel@hamburg.de \
    --cc=andrewm@uow.edu.au \
    --cc=laughing@shared-source.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®