From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 27 Jun 2001 20:08:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 27 Jun 2001 20:08:12 -0400 Received: from tsukuba.m17n.org ([192.47.44.130]:3546 "EHLO tsukuba.m17n.org") by vger.kernel.org with ESMTP id ; Wed, 27 Jun 2001 20:08:05 -0400 Date: Thu, 28 Jun 2001 09:07:52 +0900 (JST) Message-Id: <200106280007.f5S07qQ04446@mule.m17n.org> From: NIIBE Yutaka To: Marcelo Tosatti Cc: "Stephen C. Tweedie" , lkml Subject: Re: [PATCH] swapin flush cache bug In-Reply-To: In-Reply-To: <200106270051.f5R0pkl19282@mule.m17n.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Marcelo Tosatti wrote: > I think Stephen C. Tweedie has some considerations about the cache > flushing calls on do_swap_page(). Yup. IIRC, he said that flushing cache at do_swap_page() (which I've tried at first) is not good, because it's the hot path and it causes another performance problem in apache or sendmail, where many processes share the pages in swap cache. Then, the fix I sent yesterday is second try. The flush is moved to I/O routine, instead of do_swap_page(). Actually, I really wonder why current code causes no problem in other architectures. --