mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rudolf Polzer <rpolzer@durchnull.de>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: PATCH: drivers/char/vt.c allows virtually locking up nonnetworked machine
Date: Sat, 30 Jun 2001 23:10:40 +0200	[thread overview]
Message-ID: <20010630231040.A3501@www42.durchnull.de> (raw)

There is a problem concerning chvt. A normal user can run a

bash$ while [ 1 ]; do chvt 11; done

which cannot be killed using the console (only remotely, virtually never
on a nonnetworked multiuser machine). So I changed the kernel source code
so that only the superuser may change terminals.

Since renaming/deleting chvt is no solution (chvt is a simple ioctl call),
it seems to be the simplest way to prevent this. Console switching
using Ctrl-Alt-Fkey still works, as well as X, so probably there are
no implications in most cases.

But, since this may be too restrictive for some applications, I would
recommend making this a configuration option. Unfortunately I do not
know how to do this :(

--- drivers/char/vt.c.orig	Mon Jun 25 09:00:28 2001
+++ drivers/char/vt.c	Sat Jun 30 23:02:56 2001
@@ -435,10 +435,16 @@
 
 	/*
 	 * To have permissions to do most of the vt ioctls, we either have
-	 * to be the owner of the tty, or super-user.
+	 * to be the owner of the tty, or super-user. Only the superuser
+	 * if you want added security.
+	 */
+         
+	/*
+	 * disable a security hole, therefore the first check is commented
+	 * out!
 	 */
 	perm = 0;
-	if (current->tty == tty || suser())
+	if (/* current->tty == tty || */ suser())
 		perm = 1;
  
 	kbd = kbd_table + console;

             reply	other threads:[~2001-06-30 21:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-30 21:10 Rudolf Polzer [this message]
2001-06-30 22:53 ` Guest section DW
2001-06-30 22:54 ` Dan Podeanu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010630231040.A3501@www42.durchnull.de \
    --to=rpolzer@durchnull.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®