mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Robert J.Dunlop" <rjd@xyzzy.clara.co.uk>
To: Stelian Pop <stelian.pop@fr.alcove.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 2.4.6-ac2] dmi_scan.c cleanups.
Date: Mon, 9 Jul 2001 12:16:04 +0100	[thread overview]
Message-ID: <20010709121604.A14967@xyzzy.clara.co.uk> (raw)
In-Reply-To: <20010709120814.D4850@come.alcove-fr>
In-Reply-To: <20010709120814.D4850@come.alcove-fr>; from stelian.pop@fr.alcove.com on Mon, Jul 09, 2001 at 11:27:12AM +0100

On Mon, Jul 09, 2001 at 11:27:12AM +0100, Stelian Pop wrote:
> This patch cleans up the printk code in dmi_scan.c (the previous
> code gave compile warnings on enabling the printk).

A much smaller (but not necessarily better) patch would simply be:


--- arch/i386/kernel/dmi_scan.c.orig	Mon Jul  9 11:41:21 2001
+++ arch/i386/kernel/dmi_scan.c	Mon Jul  9 11:57:43 2001
@@ -15,7 +15,7 @@
 };
 
 #define dmi_printk(x)
-//#define dmi_printk(x) printk(x)
+//#define dmi_printk(x) printk x
 
 static char * __init dmi_string(struct dmi_header *dm, u8 s)
 {


-- 
        Bob Dunlop
        rjd@xyzzy.clara.co.uk
        www.xyzzy.clara.co.uk

  reply	other threads:[~2001-07-09 11:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-07-09 10:08 Stelian Pop
2001-07-09 11:16 ` Robert J.Dunlop [this message]
2001-07-10  6:33 ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010709121604.A14967@xyzzy.clara.co.uk \
    --to=rjd@xyzzy.clara.co.uk \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stelian.pop@fr.alcove.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®