From: Andreas Dilger <adilger@turbolinux.com>
To: torvalds@transmeta.com, Alan Cox <alan@lxorguk.ukuu.org.uk>,
mvw@planets.elm.net
Cc: Linux kernel development list <linux-kernel@vger.kernel.org>
Subject: [PATCH] minor fixup of quota checking
Date: Wed, 11 Jul 2001 15:22:09 -0600 (MDT) [thread overview]
Message-ID: <200107112122.f6BLM9Ik009658@webber.adilger.int> (raw)
The following patch fixes (I think) an error in the boolean logic for
checking if a filesystem can support quotas. Since quotas use both
read and write file operations, we need both functions available, but
the current test only fails if both read and write are NOT available.
Cheers, Andreas
==========================================================================
diff -ru linux-2.4.6.orig/fs/dquot.c linux-2.4.6-aed/fs/dquot.c
--- linux-2.4.6.orig/fs/dquot.c Thu Jun 28 14:28:23 2001
+++ linux-2.4.6-aed/fs/dquot.c Thu Jun 28 14:27:23 2001
@@ -1467,7 +1467,7 @@
if (IS_ERR(f))
goto out_lock;
error = -EIO;
- if (!f->f_op || (!f->f_op->read && !f->f_op->write))
+ if (!f->f_op || !f->f_op->read || !f->f_op->write)
goto out_f;
inode = f->f_dentry->d_inode;
error = -EACCES;
--
Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto,
\ would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/ -- Dogbert
reply other threads:[~2001-07-11 21:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200107112122.f6BLM9Ik009658@webber.adilger.int \
--to=adilger@turbolinux.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mvw@planets.elm.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®