From: Andreas Dilger <adilger@turbolinux.com>
To: lyons@pobox.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: ioctl bug?
Date: Fri, 13 Jul 2001 15:39:59 -0600 (MDT) [thread overview]
Message-ID: <200107132139.f6DLdxYC014544@webber.adilger.int> (raw)
In-Reply-To: <Pine.LNX.4.33.0107131139450.12456-100000@gruel.uchicago.edu> "from Gary Lyons at Jul 13, 2001 03:43:15 pm"
Gary writes:
> I think I have found a bug in the kernel.
>
> starting with 2.4.5ac23 and continuing through both 2.4.6 and
> 2.v.6-ac2 Whenever I try to do a lsattr or chattr on a directory
> I get:
>
> "Inappropriate ioctl for device While reading flags"
Yet another case of Linux pro-active bug-fixing. I have already sent
a patch for this to Linus and Alan. It seems I CC'd ext2-devel, but
not linux-kernel.
Here is the patch again. It was likely caused by Al Viro's major
overhaul of the ext2 directory code, to move it into the page cache.
Cheers, Andreas
===========================================================================
--- linux-2.4.6.orig/fs/ext2/dir.c Thu Jun 28 14:28:24 2001
+++ linux-2.4.6-aed/fs/ext2/dir.c Tue Jul 10 22:59:12 2001
@@ -576,5 +576,6 @@
struct file_operations ext2_dir_operations = {
read: generic_read_dir,
readdir: ext2_readdir,
+ ioctl: ext2_ioctl,
fsync: ext2_sync_file,
};
--
Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto,
\ would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/ -- Dogbert
prev parent reply other threads:[~2001-07-13 21:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-13 20:43 Gary Lyons
2001-07-13 21:01 ` Chris Wedgwood
2001-07-13 21:00 ` Gary Lyons
2001-07-13 21:09 ` Chris Wedgwood
2001-07-13 21:12 ` Chris Wedgwood
2001-07-13 21:24 ` Gary Lyons
2001-07-13 21:27 ` Christoph Hellwig
2001-07-13 21:39 ` Andreas Dilger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200107132139.f6DLdxYC014544@webber.adilger.int \
--to=adilger@turbolinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyons@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®