mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrea Arcangeli <andrea@suse.de>
To: "David S. Miller" <davem@redhat.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
	dpicard@rcn.com, axboe@suse.de, linux-kernel@vger.kernel.org
Subject: Re: PATCH for Corrupted IO on all block devices
Date: Wed, 18 Jul 2001 04:35:06 +0200	[thread overview]
Message-ID: <20010718043506.B32411@athlon.random> (raw)
In-Reply-To: <3B54E85E.6E917925@psind.com> <Pine.LNX.4.33.0107171840550.1175-100000@penguin.transmeta.com> <15188.61164.315022.913819@pizda.ninka.net>
In-Reply-To: <15188.61164.315022.913819@pizda.ninka.net>; from davem@redhat.com on Tue, Jul 17, 2001 at 07:05:32PM -0700

On Tue, Jul 17, 2001 at 07:05:32PM -0700, David S. Miller wrote:
> 
> Linus Torvalds writes:
>  > What filesystem do you see the bug with?
> 
> His report did specifically mention "databases".  But my initial
> impression was the same as yours, that this is a bug in the user.

it is:

--- corruption.c.orig	Wed Jul 18 04:14:15 2001
+++ corruption.c	Wed Jul 18 04:31:29 2001
@@ -22,7 +22,7 @@
                 int i, buffer[RD_BUFF_SZ];
 		fflush(fp);
                 fseek(fp, o, SEEK_SET);
-                fread(buffer, sizeof(int), sizeof(buffer), fp);
+                fread(buffer, 1, sizeof(buffer), fp);
                 printf("Validating end of file writes\n");
                 for(i = (RD_BUFF_SZ - 1); i >= 0; i--) {
                     assert(buffer[i] == --j) ;

Andrea

  parent reply	other threads:[~2001-07-18  2:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-07-18  1:37 David J. Picard
2001-07-18  1:43 ` Linus Torvalds
2001-07-18  2:37   ` Aaron Sethman
2001-07-18  2:14     ` David J. Picard
2001-07-18  2:51       ` Alexander Viro
2001-07-18  3:03       ` David S. Miller
2001-07-18  2:41     ` Aaron Sethman
2001-07-18  2:05 ` David S. Miller
2001-07-18  2:08   ` Linus Torvalds
2001-07-18  2:35   ` Andrea Arcangeli [this message]
2001-07-18  2:16 ` Alexander Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010718043506.B32411@athlon.random \
    --to=andrea@suse.de \
    --cc=axboe@suse.de \
    --cc=davem@redhat.com \
    --cc=dpicard@rcn.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®