From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
To: andrea@suse.DE (Andrea Arcangeli)
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.4.7 softirq incorrectness.
Date: Tue, 24 Jul 2001 02:24:47 +0400 (MSD) [thread overview]
Message-ID: <200107232224.CAA06983@mops.inr.ac.ru> (raw)
In-Reply-To: <20010723013416.B23517@athlon.random> from "Andrea Arcangeli" at Jul 23, 1 03:45:00 am
Hello!
> The first netif_rx is required to run from interrupt handler
No! netif_rx() is called from _any_ context. Check with grep.
So, this must be repaired in some way.
Actually, assumption that local_bh_enable() etc does not happen
with disabled irq was the biggest hole in Ingo's patch: all the functions
ever doing local_irq_save() assume that they _can_ be called with
disabled irqs (otherwise they would make local_irq_disable() instead)
and, hence, some spinlocks held.
> for the next interrupt (in old 2.4 kernels you had to wait for the next
> irq instead).
Well, not "had to", a small delay was purpose of this call yet.
Actually, now it can be replaced with a direct schedule ksoftirqd,
because we surely have softirq flood, when this place is reached.
Alexey
next prev parent reply other threads:[~2001-07-24 17:05 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-22 20:44 Rusty Russell
2001-07-22 23:34 ` Andrea Arcangeli
2001-07-23 9:06 ` Rusty Russell
2001-07-23 14:29 ` Andrea Arcangeli
2001-07-24 9:35 ` Rusty Russell
2001-07-25 19:33 ` Andrea Arcangeli
2001-07-26 20:26 ` Rusty Russell
2001-07-23 9:25 ` Kai Germaschewski
2001-07-23 11:12 ` Jeff Garzik
2001-07-23 14:18 ` Andrea Arcangeli
2001-07-23 12:05 ` David S. Miller
2001-07-23 14:31 ` Andrea Arcangeli
2001-07-23 22:24 ` Alexey Kuznetsov [this message]
2001-07-25 22:23 ` Andrea Arcangeli
2001-07-26 17:46 ` kuznet
2001-07-26 18:03 ` Jeff Garzik
2001-07-26 18:29 ` Andrea Arcangeli
2001-07-27 16:48 ` kuznet
2001-07-27 18:31 ` Maksim Krasnyanskiy
2001-07-27 18:59 ` kuznet
2001-07-27 19:21 ` Maksim Krasnyanskiy
2001-07-27 19:35 ` kuznet
2001-07-28 0:52 ` [PATCH] [IMPORTANT] " Maksim Krasnyanskiy
2001-07-28 17:41 ` kuznet
2001-07-28 18:02 ` Andrea Arcangeli
2001-07-28 19:02 ` kuznet
2001-07-28 19:32 ` Andrea Arcangeli
2001-07-28 23:28 ` Alexey Kuznetsov
2001-07-29 17:07 ` Linus Torvalds
2001-07-29 17:52 ` kuznet
2001-07-30 18:50 ` Ingo Molnar
2001-07-30 22:47 ` Nigel Gamble
2001-07-30 22:56 ` Christoph Hellwig
2001-07-31 18:08 ` kuznet
2001-07-28 17:54 ` Andrea Arcangeli
2001-07-28 19:17 ` Andrea Arcangeli
2001-07-30 18:32 ` Maksim Krasnyanskiy
2001-07-27 0:47 ` Maksim Krasnyanskiy
2001-07-27 15:01 ` Andrea Arcangeli
2001-07-27 9:34 ` David S. Miller
2001-07-27 17:01 ` kuznet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200107232224.CAA06983@mops.inr.ac.ru \
--to=kuznet@ms2.inr.ac.ru \
--cc=andrea@suse.DE \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®