From: Matthew Dharm <mdharm-kernel@one-eyed-alien.net>
To: Keith Owens <kaos@ocs.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] 2.4.8-pre3 drivers/usb/storage/scsiglue.c
Date: Mon, 30 Jul 2001 22:50:51 -0700 [thread overview]
Message-ID: <20010730225051.B14078@one-eyed-alien.net> (raw)
In-Reply-To: <32655.996545481@kao2.melbourne.sgi.com>
In-Reply-To: <32655.996545481@kao2.melbourne.sgi.com>; from kaos@ocs.com.au on Tue, Jul 31, 2001 at 12:11:21PM +1000
[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]
Hrm... there was a good reason at one point why this shouldn't be const....
Oh yeah... it's not const. id gets assigned a few lines down.
Or does the const keywork refer only to the struct, not to the pointer? If
that's the case, then the keyword should be there....
Matt Dharm
On Tue, Jul 31, 2001 at 12:11:21PM +1000, Keith Owens wrote:
> Trivial patch to remove warning message.
>
> Index: 8-pre3.1/drivers/usb/storage/scsiglue.c
> --- 8-pre3.1/drivers/usb/storage/scsiglue.c Tue, 31 Jul 2001 11:09:45 +1000 kaos (linux-2.4/y/b/2_scsiglue.c 1.4.2.1 644)
> +++ 8-pre3.1(w)/drivers/usb/storage/scsiglue.c Tue, 31 Jul 2001 12:07:28 +1000 kaos (linux-2.4/y/b/2_scsiglue.c 1.4.2.1 644)
> @@ -249,7 +249,7 @@ static int bus_reset( Scsi_Cmnd *srb )
> for (i = 0; i < us->pusb_dev->actconfig->bNumInterfaces; i++) {
> struct usb_interface *intf =
> &us->pusb_dev->actconfig->interface[i];
> - struct usb_device_id *id;
> + const struct usb_device_id *id;
>
> /* if this is an unclaimed interface, skip it */
> if (!intf->driver) {
--
Matthew Dharm Home: mdharm-usb@one-eyed-alien.net
Maintainer, Linux USB Mass Storage Driver
I'm a pink gumdrop! How can anything be worse?!!
-- Erwin
User Friendly, 10/4/1998
[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]
next prev parent reply other threads:[~2001-07-31 5:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-31 2:11 Keith Owens
2001-07-31 5:50 ` Matthew Dharm [this message]
2001-07-31 6:21 ` Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010730225051.B14078@one-eyed-alien.net \
--to=mdharm-kernel@one-eyed-alien.net \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®