Oops in dmi_table() from Linux 2.4.7

[Lars Aronsson <lars@aronsson.se>]

Hi guys, it's me again,


My previously reported problem has its roots here:

	Linux 2.4.7
	file arch/i386/kernel/dmi_scan.c
	function dmi_table()
	the if() statement for breaking out of the loop.

What happened on my hardware is that dm->type == 255 (this happens the
very first time these statements are executed), which I guess
indicates that there are no DMI data on my hardware/BIOS.  The type of
dm->type is u8, which means the loop is not broken.  I have no idea
about the DMI specs, so I don't know how other values of dm->type
should be interpreted.  The function dmi_decode() only uses 0,1,2,3.
A simple cast to signed char fixed the problem for me:

	if (((signed char)dm->type) < last) break;

Again, my hardware is a Toshiba Portege 7020CT.  I think I did some
BIOS update when I first installed support for the Dock II docking
station, but I won't care to dig up bios version info unless you say
you need it.

Again, hope you can use this.


Lars Aronsson.
-- 
  Aronsson Datateknik
  Teknikringen 1e              tel +46-70-7891609     lars@aronsson.se
  SE-583 30 Linköping, Sweden  fax +46-13-211820    http://aronsson.se