From: Andrey Savochkin <saw@saw.sw.com.sg>
To: Martin Knoblauch <Martin.Knoblauch@TeraPort.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: eepro100.c - Add option to disable power saving in 2.4.7-ac7
Date: Mon, 6 Aug 2001 09:10:22 -0700 [thread overview]
Message-ID: <20010806091022.A32579@saw.sw.com.sg> (raw)
In-Reply-To: <3B6EBC34.9578EA4E@TeraPort.de>
In-Reply-To: <3B6EBC34.9578EA4E@TeraPort.de>; from "Martin Knoblauch" on Mon, Aug 06, 2001 at 05:48:04PM
Hi,
Making it an option looks like a reasonable idea.
However, could you mind the indentation style of the driver, please?
On Mon, Aug 06, 2001 at 05:48:04PM +0200, Martin Knoblauch wrote:
> after realizing that my first attempt for this patch was to
> enthusiastic, I have no a somewhat stripped down version. Compiles
> against 2.4.7-ac7.
>
> The patch adds the option "power_save" to eepro100. If "1" (default),
> power save handling is done as normal. If "0", no power saving is done.
> This is to workaround some flaky eepro100 adapters that do not survive
> D0->D2-D0 transitions.
[snip]
> @@ -1833,7 +1842,8 @@
> if (speedo_debug > 0)
> printk(KERN_DEBUG "%s: %d multicast blocks dropped.\n", dev->name, i);
>
> - pci_set_power_state(sp->pdev, 2);
> + if (power_save)
> + pci_set_power_state(sp->pdev, 2);
>
> MOD_DEC_USE_COUNT;
>
Best regards
Andrey
next prev parent reply other threads:[~2001-08-06 16:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-06 15:48 [PATCH] " Martin Knoblauch
2001-08-06 16:10 ` Andrey Savochkin [this message]
2001-08-06 16:49 ` Kai Germaschewski
2001-08-07 10:35 ` [PATCH] eepro100.c - Add option to disable power saving in2.4.7-ac7 Martin Knoblauch
2001-08-07 20:55 ` [PATCH] eepro100.c - Add option to disable power saving in 2.4.7-ac7 Admin Mailing Lists
2001-08-08 7:26 ` [PATCH] eepro100.c - Add option to disable power saving in2.4.7-ac7 Martin Knoblauch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010806091022.A32579@saw.sw.com.sg \
--to=saw@saw.sw.com.sg \
--cc=Martin.Knoblauch@TeraPort.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®